Creating folder.jpg within MP -> Movies -> IMDB lookup

[BoelShit]

When looking up movie information in MP (IMDB option), MP automatically creates a folder.jpg from the downloaded coverart. This does not occur when looking up movie information through the MP configuration btw.

The created folder.jpg is low on quality where as it used to be high in quality. I don't know from which SVN it doesnt work anymore.

bug description:

1. start mediaportal
2. go to MyMovies
3. set movie view to share!!!
4. go to a Movie folder without coverart
5. click right mousebutton and choose IMDB from menu
6. let it download movie info and pick a coverart
7. go back with ESCAPE
8. see that the folder coverart is a low quality image where as the IMDB screen showed a high quality image
9. check the movie folder in explorer. The folder.jpg is just a couple KB in size and small in resolution

Fix:

I've dusted off some coding skills (LOL) and downloaded the sourcecode.
The code handling this is located in GUIVideoInfo.cs. The code does a ConvertToLargeCoverArt from the normal coverImageArt which is (I think) not needed to perform as the good quality coverart is also downloaded and saved in the corresponding Thumb folder.

I changed the code so that it can use both normal coverImageArt and largeCoverImageArt where the largeCoverImageArt has priority.
Now it saves a folder.jpg based on the better quality coverart and if not present it uses the lower quality based one.

I only have tested it to see if it creates the high quality coverart which it does. Couldnt check what happens when the largeCoverArt isnt available but it should then work with the normal coverArt. Hoping to see this fixed with my adjustments or in another way (as long as it gets fixed ).

attachments:

I've attached a pre-build WindowsPlugins.dll (for easy testing) and the editted GUIVideoInfo.cs

EDIT/UPDATE! New WindowsPlugin.dll added compiled against SVN Revision:17388 (SVN-Snapshot: 02-14-2008 05-04h - Revision:17388)

Just replace or rename the old WindowsPlugin.dll with the new one in the archive.

GUIVideoInfo.zip contains the source code for the change!

[rekenaar]

I will download and test later today. Thanks for the suggestion.

I hope the developers can pick up and implement your suggestion - I have also suggested a codefix a week ago, but it was not yet implemented. I guess (hope) the devs are too busy with infinity

[BoelShit]

I noticed... Hope they will fix this though... saves me the manual copying from Thumbs folder to the movie folder and renaming it. I hate to do that for 150+ movies

[emphatic]

Has this been added yet to a recent SVN build? And btw, is MediPortal supposed to overwrite the thumb in a folder if there's already a folder.jpg present?

I will also download your fix and test in my setup. Thanks.
Emph

[BoelShit]

This hasnt been added to SVN yet. I guess due to MP2 and the lack of testers confirming the "bug". If you need a newer WindowsPlugin.dll compiled to the latest MP source let me know and I'll add it.

The folder.jpg is as I can see is only overwritten when you do an IMDB lookup and change the cover image from the IMDB screen and then close that screen. If you already have a folder.jpg in the movie folder the IMDB screen shows that folder.jpg as cover nr.1 and won't overwrite it.

Hope this fix works for you also so it can be added to the source.

[emphatic]

I've downloaded your .zip but I don't really understand where to put the GUIVideoInfo.cs? I've searched my MediaPortal directory, but couldn't find it.

Emph

[BoelShit]

The GUIVideoInfo.cs is the source file for the devs which I have edited. You dont need to put it anywhere. The WindowsPlugin.dll has to be put in MPinstalldir\Plugins\Windows.

[emphatic]

Okay. Tested and working! Great job!
Emph

[snoekieboe]

I'm experiencing the same problem on my MP machine.
Very low quality IMDB images, but the problem seems to be solved after implementing Boelshits fix.

Perhaps if more people notice the bug it could get included into the next SVN?

[DennisNL]

Bug confirmed by me too...