Quote:
Originally Posted by Maschine  I looked at your patch today. I'm sorry, but I won't integrate it to our SVN. The patch itself is fine, all your changes look good, but more changes need to be done, especially within the configuration app. |
Maybe I'm missing something: the DiskManagement was already there, it was simply disabled and not fully developed. There were a plan with it ?
I've tried to contact Frodo (the developer that posted it for the first time) with a PM but didn't get reply yet.
I've fixed the DiskManagement class because I really need that feature (my 500GB hd was filled with recordings!
)
Maybe we could fully plan the disk management feature here ?
Quote:
Originally Posted by Maschine 1) Deleting recordings is a very critical topic. Many users don't want MP to delete anything. They'll prefer loosing the new recording (which can't start because of no disk space) over getting their old files deleted. So we need a general option to turn diskmanagement completely off. |
Sure, I completely agree with you.
How we could implement this ?
1- adding a boolean to the settings (with a checkbox in SetupTV and verifing that setting in DiskManagement)
2- setting the default disk quota to zero (at the moment in DiskManagement if the quota is less than 50MB or unreadable it is set to 50MB and the delete process will continue)
The second option is less invasive so I would prefer it.
Quote:
Originally Posted by Maschine 2) The check for free disk space is currently done for all drives on the computer. Imagine a scenario with 1 system disk and 1 disk for recordings. The system disk has just 200 MB free space while the recordings disk still has 50+GB free space. Diskmanagement will start to delete one recording after another because the system disk won't get any more space. ==> Diskmanagement should only monitor those drives that actually contain recordings (i.e. the recordings folder is on those disks). |
No, this scenario can't happen. DiskManagement work this way:
1- it get a list of drives in the system
2- for each drive in the list start the procedure:
2.1- check disk space on drive
2.2- get quota setting for drive (if less than 50MB or unreadable it set to 50MB)
2.3- get
recordings on drive
2.4- sort recordings by date
2.5- delete recordings until disk quota is reached (NOTE: it delete
only recordings with the "
Keep until space is needed" property)
Quote:
Originally Posted by Maschine If you add those 2 points, I can add your patch to the official builds. In its current state I need to reject it, sorry.
I hope you understand my descission and "fix" the 2 mentioned issues, because -as I said above- your code itself is fine. |
No problem. Let take a decision together.
Bye