Playlist titles empty after 1st page (Faulty commit)

[vladyman]

After one of the recent SVN updates I get the following bug: In the music playlist, all the titles are shown on the first page, but as soon as you scroll down, all the song names are empty, even though if you select it, the name is shown correctly on the top.

I did not see any relevant commits to the Playlist module, so the bug probably somewhere else, but I didn't get a chance to debug it yet.

Any ideas?

[vladyman]

Ok, I found the reason for this. On the 14.03.2007 there was a commit by yamp (with no comment) which added the following lines to GUIPlayListItemListControl.cs:

if (buttonNr + _offset < 0 || buttonNr + _offset >= _listButtons.Count) return;
if (buttonNr  < 0 || buttonNr  >= _listButtons.Count) return;

I guess this was supposed to save some resources and not always reading in all of the titles. However this lead to the issue that I am having (and I don't think I am the only one as I tried it on a clean install).

Removing these lines solves the issue, but I suppose they need to be altered in a way that they work (I haven't looked into the code in much detail yet).



Patch is attached.

[Funky]

Hello,

I can confirm this.

1. Go into music.
2. Add songs to the playlist, so that they cover more than 1 screen.
3. Go to the playlist
4. Scroll down
5. The text on the items do not show.

MediaPortal Version: SVN From 17/3
MediaPortal Skin: Blue Two Wide
Windows Version: win xp sp2 Swedish
CPU Type: AMD Athlon 64 x2 4600+
HDD: Hitachi 500gb
Memory: 3328 MB DDR SDRAM
Motherboard: Gigabyte NF-CK804
Motherboard Chipset: NFORCE4
Motherboard Bios: Award F2
Video Card: ASUS EN7600GS TOP SILENT/HTD/512M
Video Card Driver: 9371
Sound Card:
Sound Card AC3: Coax out
Sound Card Driver:
1. TV Card: Haupaugge MCE500
1. TV Card Type: Analog
1. TV Card Driver: 23074
2. TV Card:
2. TV Card Type:
2. TV Card Driver:
3. TV Card:
3. TV Card Type:
3. TV Card Driver:
4. TV Card:
4. TV Card Type:
4. TV Card Driver:
MPEG2 Video Codec: DScaler
MPEG2 Audio Codec: ffdshow
Satelite/CableTV Provider:
HTPC Case: Silverstone LC03V
Cooling:
Power Supply:
Remote: MCE European
TV: Philips 300wn5s
TV - HTPC Connection: DVI

[vladyman]

Apparently this was fixed now in SVN, but nobody seems to care in the forum. Oh well, as long as it works...

[ronilse]

Hi,
Spotted this in the weekend, but had to wait for a dev to fix it.
Of course we care, but not able to read every post to forum all the time

Regards
Roy

[vladyman]

No probs I know you guys are busy, I was just surprised that things get fixed by themselves