Getting comments on my patch

Sven · 2007-09-08, 16:18

Hi,

more than seven months ago, I wrote a patch implementing "proper" WinLIRC support for MediaPortal. Unfortunately, no developer has ever commented on that patch. Did just no-one notice my post publishing the patch or is there a reason why it is not merged? Is there any chance the patch will be accepted?

Sven

ziphnor · 2007-09-10, 16:23

I think in general that only the developers that are familiar with the affected part of the code will be willing to include such a patch. You should really check the SVN log files and see who created (or just worked alot) on the affected areas of MediaPortal.

Afterwards i suggest you contact them on IRC, as thats usually a safer bet than the forums.

I'm sorry that your patch has been lying around for 7 months, i hope it wont discourage you from future contributions (though i guess thats little comfort

.

diehard2 · 2007-09-10, 17:50

Hi Sven,

I'll take a look at it, but as it might introduce problems, I will have to wait until after the next major release. Bump this is it doesn't happen then.

Sven · 2007-09-15, 15:46

Thanks for your answers.

Quote:

Originally Posted by diehard2

I'll take a look at it, but as it might introduce problems, I will have to wait until after the next major release. Bump this is it doesn't happen then.

That's fine, thanks.

Sven

Sven · 2007-12-16, 11:01

Quote:

Originally Posted by diehard2

Bump this is it doesn't happen then.

Bump!

Darre · 2007-12-16, 13:10

I think the feature freeze is stopping them from adding it now.. they probably wont untill MP 1.0 is out.

2007-09-08, 16:18	#1 (permalink)
Sven Portal Member Join Date: Jan 2007 Posts: 39 Thanks: 1 Thanked 1 Time in 1 Post Country:	Getting comments on my patch Hi, more than seven months ago, I wrote a patch implementing "proper" WinLIRC support for MediaPortal. Unfortunately, no developer has ever commented on that patch. Did just no-one notice my post publishing the patch or is there a reason why it is not merged? Is there any chance the patch will be accepted? Sven

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
New HTPC project -- comments more than welcome!	hansb	Ongoing HTPC Projects	15	2006-10-01 16:42
RC3 comments	AlexS	The old Bugreport Forum	1	2006-03-19 07:35
Skin idea. Comments please.	tacroy	Skins	12	2006-01-18 01:12
Any comments?	reebokman	HTPC Projects	11	2005-12-16 09:08
Need comments on HTPC Specs	BorgmanJayce	HTPC Projects	14	2005-11-29 23:21

2007-09-10, 16:23	#2 (permalink)
ziphnor Portal Developer Join Date: Aug 2005 Location: Copenhagen Age: 29 Posts: 709 Thanks: 0 Thanked 9 Times in 6 Posts Country: My System	I think in general that only the developers that are familiar with the affected part of the code will be willing to include such a patch. You should really check the SVN log files and see who created (or just worked alot) on the affected areas of MediaPortal. Afterwards i suggest you contact them on IRC, as thats usually a safer bet than the forums. I'm sorry that your patch has been lying around for 7 months, i hope it wont discourage you from future contributions (though i guess thats little comfort .

2007-09-10, 17:50	#3 (permalink)
diehard2 Portal Developer Join Date: Apr 2006 Location: Chicago Posts: 513 Thanks: 2 Thanked 13 Times in 9 Posts Country:	Hi Sven, I'll take a look at it, but as it might introduce problems, I will have to wait until after the next major release. Bump this is it doesn't happen then.

2007-12-16, 13:10	#6 (permalink)
Darre Portal Member Join Date: Apr 2007 Age: 23 Posts: 829 Thanks: 94 Thanked 71 Times in 54 Posts Country:	I think the feature freeze is stopping them from adding it now.. they probably wont untill MP 1.0 is out.