Help needed with DVB subtitles

[tourettes]

Originally Posted by risu

Is there any need for additional finnish streams, I guess you can get those yourself?

Yep, I can get those by myself

Originally Posted by risu

Like I said before, timing was ok on the first release if it didn't get advanced or late. That early/late delay doesn't change if you don't touch anything. Like the decoding of timestamps were correct but wasn't applied to directx surface at the right moment when it does that. If subs came too early they came too early the whole time. I'm not sure if I could explain this clearly, I hope you understood what I meant

Decoding the (PTS) timestamps from the transport stream shouldn't have any bugs (same decoding code is used in multiple places of tv engine 3) and based on the values I get from there it's working ok.

The issue comes from the mapping of those PTS values to the current position of the stream. If someone want's to look at it the spesific code is in CDVBSub.cpp in the following methods.

CDVBSub::NotifySubtitle()
CDVBSub::Reset()
CDVBSub:: SetPcr( ULONGLONG pcr )

There isn't that much code in those methods, but debugging can still be annoying

[tourettes]

Originally Posted by Nyll

About the sync problem: Looks like there is no sync problem, when I playback a recorded ts-stream in the TV-section in Mediaportal. The sync problem only occur when watching live TV.

Ok, that sounds good. Is this the case with other testers also?

btw. I haven't tested the live tv almost at all.

[zombiepig]

hey tourettes - i'm trying to get you a sample from aus, but if i record the ts and view it in vlc i can't find any subtitles in the file. does this mean the file will be useless to you, or is it a problem with vlc?
also, how large a file are you after?

[tourettes]

Originally Posted by zombiepig

hey tourettes - i'm trying to get you a sample from aus, but if i record the ts and view it in vlc i can't find any subtitles in the file. does this mean the file will be useless to you, or is it a problem with vlc?
also, how large a file are you after?

I would doubt that VLC has any issues with subtiltes (at least in my testing it has been working always ok) so I would say that the sample will be useless. approx 50MB should be enough.

[tourettes]

Originally Posted by Seidelin

I am using TVE3 from April 2nd, and second test version of tourettes subtitle filters.

Some times when I stop playing a video file MP crashes. It appears that the directshow filters are not closed down succesfully as far as I can read the attached logs.

Regards
Seidelin

New version of the filter available. This version should fix those crashes (althou I did only see hangs, but I think they are caused by the same thing -> not DS objects were freed properly).

http://day2.no-ip.org/DVBSub_test_03.zip

[Seidelin]

I just installed this third version, and it seems to fix the issue I was having (and yes it was hangs, not crashes, sorry).

The only major issue I see now, is the subtitles are not removed, but hangs around for way too long when there is silence. The timing of presenting the subtitles looks reasonable close, but there is some random offset when tuning to a live stream making a timestep (even forward) solves the timing issue more or less.

Regards
Seidelin

[tourettes]

Originally Posted by Seidelin

I just installed this third version, and it seems to fix the issue I was having (and yes it was hangs, not crashes, sorry).

Nice to hear that those hangs are fixed now.

Originally Posted by Seidelin

The only major issue I see now, is the subtitles are not removed, but hangs around for way too long when there is silence. The timing of presenting the subtitles looks reasonable close, but there is some random offset when tuning to a live stream making a timestep (even forward) solves the timing issue more or less.

Looks like broadcasters are using a little bit odd subtitle timeouts. For example BBC is using always 30 seconds!

I think we need to ignore those timeouts that are in the subtitle stream and start to use some defined value. Any good suggestion how long the subtitle timeout should be? Is 3 seconds enough?

About the live tv, I have no clue yet.

[Seidelin]

Originally Posted by tourettes

Looks like broadcasters are using a little bit odd subtitle timeouts. For example BBC is using always 30 seconds!

I think we need to ignore those timeouts that are in the subtitle stream and start to use some defined value. Any good suggestion how long the subtitle timeout should be? Is 3 seconds enough?

I have timed the analog cable subtitles here in Denmark, and the display time varies between approx 2.5 s and 4.5 s. I would say that 3 s is a bit too short, but if the timeout values are either way off or close, then the timing could be something like:
If timeout > 6 s or timeout < 1 s then timeout = 5 s

A kind of sanity check on the timeout you might say.

Regards
Seidelin

[SciDoctor]

Works very well with the UK streams on MENDIP transmitter.

I vote for the 5 second timeout as in

If timeout > 6 s or timeout < 1 s then timeout = 5 s


All that is now needed is the GUI implementation of the subtitles on/off selection.

Great work thanks.

[tourettes]

http://day2.no-ip.org/DVBSub_test_04.zip available. It has that 1< timeout > 6 -> 5 seconds timeout implemented.

I also enabled the logging in the release builds, so it should be easier to fix the remaining issues.

Timing was working ok with that version in single seat live tv and and recorded tv. Streaming live tv or recorded shows is not working (timing is off really badly and seeking causes it to get lost completely). But 'm not focusing to fix that multiseat stuff before everything in single seat mode is working as I myself don't need multiseat support