New DVB subtitle filter (TsReader based)

[Seidelin]

Originally Posted by tourettes

Logs didn't show anything special. So I'll have to try to trigger those crashes by myself also. Are you sure that those crashes aren't also happening with the unmodified TsReader?

I have now tested with the plain tsreader.ax - and also produces missing audio when zapping. Also a recurrence of the "infinite nvidia icons" is seen under certain circumstances (will do a bug report in the proper thread). No conclusions about crashes - I will continue testing.

Edit: Changing channels between audio: mpeg1 and mpeg2 channels on same card repeatedly crashes plain tsreader.

Regards
Seidelin

[tourettes]

Originally Posted by Seidelin

I have now tested with the plain tsreader.ax - and also produces missing audio when zapping. Also a recurrence of the "infinite nvidia icons" is seen under certain circumstances (will do a bug report in the proper thread). No conclusions about crashes - I will continue testing.

Edit: Changing channels between audio: mpeg1 and mpeg2 channels on same card repeatedly crashes plain tsreader.

Regards
Seidelin

Thanks for testing. Those "infinite nvidia icons" are caused definately by a resource leak in TsReader (as it happens with the plain TsReader also). Thanks. Makes my debugging a lot easier. It would be even easier if you could pin point the exact TsReader version that still works (and the one that is not working for you).

[Seidelin]

Originally Posted by tourettes

Thanks for testing. Those "infinite nvidia icons" are caused definately by a resource leak in TsReader (as it happens with the plain TsReader also). Thanks. Makes my debugging a lot easier. It would be even easier if you could pin point the exact TsReader version that still works (and the one that is not working for you).

Ok, I will continue testing. Who needs sleep anyway?
Edit: It seems "infinite nvidia icon" was never fully fixed.

Regards
Seidelin

[tourettes]

Originally Posted by Seidelin

Ok, I will continue testing. Who needs sleep anyway?
Edit: It seems "infinite nvidia icon" was never fully fixed.

Regards
Seidelin

Thanks again for your effort. I think the "infinite nvidia icon" issue (resource leak) was fixed last time, but there must be some new leak introduced (and that leak doesn't seem to happen every time).

[Seidelin]

Originally Posted by tourettes

Thanks again for your effort. I think the "infinite nvidia icon" issue (resource leak) was fixed last time, but there must be some new leak introduced (and that leak doesn't seem to happen every time).

SORRY!
It turns out that the bug dissappeared when I properly uninstalled
regsvr32 /u dvbsub2.ax

At least, I cannot reproduce the bug now. Also no crashes when zapping back and forth with proper vanilla tsreader.ax. This goes for these revisions 15297, 15307 and 15418.

I wasn't aware of how much to unregister/disable to avoid having an active dvbsub2.ax filter, sorry.
EDIT: Just confirmed that reregistering dvbsub2.ax and setting dvbsubtitles=yes makes the bug surface - i.e. using vanilla TsReader plus DVBsub2.


Regards
Seidelin

[tourettes]

Originally Posted by Seidelin

SORRY!
It turns out that the bug dissappeared when I properly uninstalled
regsvr32 /u dvbsub2.ax

At least, I cannot reproduce the bug now. Also no crashes when zapping back and forth with proper vanilla tsreader.ax. This goes for these revisions 15297, 15307 and 15418.

I wasn't aware of how much to unregister/disable to avoid having an active dvbsub2.ax filter, sorry.
EDIT: Just confirmed that reregistering dvbsub2.ax and setting dvbsubtitles=yes makes the bug surface - i.e. using vanilla TsReader plus DVBsub2.

hmm... that's pretty odd, sounds like the DVBSub2.ax would be leaking some resource when it's loaded (and not used at all, as the vanilla TsReader.ax is not connecting to the DVBSub2.ax filter. Or at least it shouldn't, could you make sure that the connection is not visibled between TsReader and DVBSub2 in GraphEdit?). I'll have to debug that a little bit this evening (and more tomorrow when I have full day available for MP / coding. So let's hope there will be a rainy day

[Seidelin]

Originally Posted by tourettes

hmm... that's pretty odd, sounds like the DVBSub2.ax would be leaking some resource when it's loaded (and not used at all, as the vanilla TsReader.ax is not connecting to the DVBSub2.ax filter. Or at least it shouldn't, could you make sure that the connection is not visibled between TsReader and DVBSub2 in GraphEdit?). I'll have to debug that a little bit this evening (and more tomorrow when I have full day available for MP / coding. So let's hope there will be a rainy day

Yes. I agree that it sounds odd. Actually, I checked it last night that there was no connection between dvbsub2.ax and tsreader.ax in graphedit. It didn't look important to me at the time.

In hopes of rain
Seidelin

[tourettes]

Originally Posted by Seidelin

Yes. I agree that it sounds odd. Actually, I checked it last night that there was no connection between dvbsub2.ax and tsreader.ax in graphedit. It didn't look important to me at the time.

In hopes of rain
Seidelin

This seems to be really nasty leak. Nothing inside DVBSub2.ax seems to leak. Leak happens when DVBSub2.ax is loaded vanilla TsReader so there isn't even happening that much on the filter side. I tried also look into MP side of the code, but couldn't find anything there.

Also the DVBSub2.ax filter gets deleted properly and still the threadn count increases by one in the MediaPortal precess every time when a .ts file is started and then stopped.

[tourettes]

A new version available, please see the first post.

- Log gets deleted everytime when filter is created
- Fixed a resource leak in TsReader & DVBSub (could fix some hangs when zapping)
- Fixed sometimes pressing stop hangs
- Fixed subtitles leaked sometimes (inside MP, when user is not in the full screen tv view)
- Added support for rendering the subtitles in the video overlays

[tourettes]

New SVN MediaPortal build available (needed for the version 3 fixes / changes) http://forum.team-mediaportal.com/me...17-t26330.html