[patch] bugfix: memory leak in TStreamBufferPlayer9

cpp2005 · 2007-06-07, 19:21

While working on something else, I discovered that tsfilesource destructor is always crashing when releasing its filter's graph. The exception is caught inside Marshal.ReleaseComObject call, so nobody can see this crash.
All this happens in Cleanup() method of TStreamBufferPlayer9, which looks like this:

Code:

        ...
        if (_vmr9 != null)
        {
          Log.Info("TSStreamBufferPlayer9: vmr9 dispose");
          _vmr9.Dispose();
          _vmr9 = null;
        }
        ...
        DirectShowUtil.RemoveFilters(_graphBuilder); //here tsfilesource is released
        ....

I found that if _vmr9 is released after tsfilesource, the crash is gone! Don't know what exactly _vmr9 is doing that causes the crash.
Here is the patch on sourceforge.

Broceliande · 2007-06-08, 07:11

Hi , you spotted an issue we were looking into since a while now.
This one was causing crashes after 21 files were played ...
Thx for your patch , it's in svn now and will be tested .

2007-06-07, 19:21	#1 (permalink)
cpp2005 Portal Member Join Date: Nov 2006 Posts: 52 Thanks: 0 Thanked 6 Times in 3 Posts	[patch] bugfix: memory leak in TStreamBufferPlayer9 While working on something else, I discovered that tsfilesource destructor is always crashing when releasing its filter's graph. The exception is caught inside Marshal.ReleaseComObject call, so nobody can see this crash. All this happens in Cleanup() method of TStreamBufferPlayer9, which looks like this: Code: ... if (_vmr9 != null) { Log.Info("TSStreamBufferPlayer9: vmr9 dispose"); _vmr9.Dispose(); _vmr9 = null; } ... DirectShowUtil.RemoveFilters(_graphBuilder); //here tsfilesource is released .... I found that if _vmr9 is released after tsfilesource, the crash is gone! Don't know what exactly _vmr9 is doing that causes the crash. Here is the patch on sourceforge.

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
[patch] bugfix: subtitles configuration is not used	cpp2005	General Development (no feature request here!)	31	2007-08-22 01:37
Memory leak -	PodgeMaster	support	5	2007-01-18 19:27
Memory leak in 2.1.0 ?	imported_Michael	Media Portal - Allgemeines	3	2006-10-29 19:13
Memory Leak on MP 0.2.0	japelweb	General Support	4	2006-02-18 12:13
[Patch] Bugfix: Channel zapping stops working	Vic	General Development (no feature request here!)	0	2005-03-12 09:16

2007-06-08, 07:11	#2 (permalink)
Broceliande Portal Developer Join Date: Apr 2006 Posts: 189 Thanks: 0 Thanked 1 Time in 1 Post	Hi , you spotted an issue we were looking into since a while now. This one was causing crashes after 21 files were played ... Thx for your patch , it's in svn now and will be tested .