[Patch]Fix & improve vobsub-haali cooperation

peterk2007 · 2007-10-24, 20:13

Hi everyone,

I've found out, that if Haali splitter installed with avi support, then vobsub autoload feature don't work on avi files with external subtitles (srt, sub, etc.). No matter how you set up vobsub, enable or disable haali's vobsub
autoload feature, it just doesn't work. Adding vobsub in mediaportal as postprocessing filter also does not solve the problem, because vobsub won't be included in the graph on rendering.

Since Haali's splitter otherwise works really great for avi-s too (for example handling avi files with multiple audio streams, etc) this haali bug (i guess) can be quite annoying.

So I made this pach to fix this issue in mediaportal. It does the following:

1. Looks for vobsub filter after the graph has been rendered.
2. If vobsub is there - either the autoloading or the "normal" version - then checks if it is properly connected. Checks for both the video and subtitle pins.
3. If the video pins are not connected, then inserts vobsub right before the vmr9 renderer.
4. If the subtitle input pin is not connected, then looks for haali splitter, and if it is there, then connects haali's subtitle output pin (if any) to vobsub.
5. Finally makes vobsub to refresh available subtitle streams (reloading available external subtitle info).

So with this patch, basically and generally you will be able to fix "vobsub not loading issues". Simply add vobsub as postprocessing filter, and then vobsub will always load and connect properly into the graph providing subtitles whenever possible. (If you added vobsub as postprocessing filter, you can disable autoloading in vobsub config, and also in haali config.)

This patch does not affect vobsub autoloading functionality. If vobsub autoloaded and connected properly, the patch does not touch it.

Affected files: VideoPlayerVMR9.cs, VMR9.cs

I used the latest SVN files (rev 16346)

I have submitted the patch to the tracker: Here

Cheers.

bmfrosty · 2007-11-25, 06:49

Was this patch ever applied? I'm using the 0.2.3.0 release and am running into this problem. I'm having to remux ogm+ssa files to work around the problem.

Darre · 2007-11-25, 11:26

Im also having trouble gettings subs to show up in MP. About exactly the problem that should have been fixed by this patch actually..

2007-10-24, 20:13	#1 (permalink)
peterk2007 Portal Member Join Date: Apr 2007 Posts: 15 Thanks: 0 Thanked 4 Times in 3 Posts Country:	[Patch]Fix & improve vobsub-haali cooperation Hi everyone, I've found out, that if Haali splitter installed with avi support, then vobsub autoload feature don't work on avi files with external subtitles (srt, sub, etc.). No matter how you set up vobsub, enable or disable haali's vobsub autoload feature, it just doesn't work. Adding vobsub in mediaportal as postprocessing filter also does not solve the problem, because vobsub won't be included in the graph on rendering. Since Haali's splitter otherwise works really great for avi-s too (for example handling avi files with multiple audio streams, etc) this haali bug (i guess) can be quite annoying. So I made this pach to fix this issue in mediaportal. It does the following: 1. Looks for vobsub filter after the graph has been rendered. 2. If vobsub is there - either the autoloading or the "normal" version - then checks if it is properly connected. Checks for both the video and subtitle pins. 3. If the video pins are not connected, then inserts vobsub right before the vmr9 renderer. 4. If the subtitle input pin is not connected, then looks for haali splitter, and if it is there, then connects haali's subtitle output pin (if any) to vobsub. 5. Finally makes vobsub to refresh available subtitle streams (reloading available external subtitle info). So with this patch, basically and generally you will be able to fix "vobsub not loading issues". Simply add vobsub as postprocessing filter, and then vobsub will always load and connect properly into the graph providing subtitles whenever possible. (If you added vobsub as postprocessing filter, you can disable autoloading in vobsub config, and also in haali config.) This patch does not affect vobsub autoloading functionality. If vobsub autoloaded and connected properly, the patch does not touch it. Affected files: VideoPlayerVMR9.cs, VMR9.cs I used the latest SVN files (rev 16346) I have submitted the patch to the tracker: Here Cheers.

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
[patch] A possible fix for some resume from standby/hibernation problems	ziphnor	General Development (no feature request here!)	17	2006-09-27 07:30
Haali MediaSplitter VS. VobSuB & mkv	wizard84	Codecs, External Players	11	2006-04-18 13:41
patch:fix for scanning music w/ numbers in album/artist name	zombiepig	General Development (no feature request here!)	0	2005-11-24 09:45
[Patch] My TV OSD / ZAPOSD stuttering fix	FlipGer	General Development (no feature request here!)	18	2005-03-10 18:05
patch to fix some Unicode-related issues in MP3 tags	Anonymous	Plugins	0	2004-11-14 07:05

2007-11-25, 06:49	#2 (permalink)
bmfrosty Portal User Join Date: Nov 2007 Posts: 1 Thanks: 0 Thanked 0 Times in 0 Posts Country:	Was this patch ever applied? I'm using the 0.2.3.0 release and am running into this problem. I'm having to remux ogm+ssa files to work around the problem.

2007-11-25, 11:26	#3 (permalink)
Darre Portal Member Join Date: Apr 2007 Age: 23 Posts: 829 Thanks: 94 Thanked 71 Times in 54 Posts Country:	Im also having trouble gettings subs to show up in MP. About exactly the problem that should have been fixed by this patch actually..