[patch] Missing end line characters in textscrollup control

zebons · 2007-05-27, 16:01

Hi,
I notice a bug with textscrollup controls : in some cases, end lines characters are missing. The problem didn't exist in previous versions.
If I replace in my skin the control by a simple textbox, there is no problem (but no scrolling of course...).
I compared the two codes GUITextScrollUpControl.cs and GUITextControl.cs and noticed a difference for the calcul of the dMaxWidth value.
So I took a look on SVN's version of the GUITextScrollUpControl.cs and found the origin of the difference in revision 10242 of that code.
At line 237 of the actuel code (215 in the previous one), I replace the code :
int dMaxWidth = _width - ixoff;
by
int dMaxWidth = _width + ixoff;
as it was previously and now it seems to work properly. See doc joined.

Can you validate my opinion and if it's good modify the actual code to integrate in future SVN ?
Thanks

-Manfred- · 2007-05-28, 21:56

I can confirm this. Long lines and last chars missing, quite annoying bug when scrolling EPG data. Please fix this.

-M-

2007-05-27, 16:01	#1 (permalink)
zebons Portal Member Join Date: Feb 2006 Posts: 433 Thanks: 2 Thanked 28 Times in 21 Posts	[patch] Missing end line characters in textscrollup control Hi, I notice a bug with textscrollup controls : in some cases, end lines characters are missing. The problem didn't exist in previous versions. If I replace in my skin the control by a simple textbox, there is no problem (but no scrolling of course...). I compared the two codes GUITextScrollUpControl.cs and GUITextControl.cs and noticed a difference for the calcul of the dMaxWidth value. So I took a look on SVN's version of the GUITextScrollUpControl.cs and found the origin of the difference in revision 10242 of that code. At line 237 of the actuel code (215 in the previous one), I replace the code : int dMaxWidth = _width - ixoff; by int dMaxWidth = _width + ixoff; as it was previously and now it seems to work properly. See doc joined. Can you validate my opinion and if it's good modify the actual code to integrate in future SVN ? Thanks Last edited by zebons; 2007-05-27 at 16:26.

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Remote control missing Teletext functions.	Al_Capone	0.2.2.0 Final and SVN Builds	4	2007-07-21 23:17
Different teletext characters? Possible?	NLS	General Support	0	2006-05-18 22:30
Asian characters support	beefturkey	General Support	2	2006-05-08 20:46
explorer plugin and [ ] characters	YYota	The old Bugreport Forum	8	2006-03-16 23:31
Special characters on the VFD	csabal	Plugins	2	2005-09-28 22:39

2007-05-28, 21:56	#2 (permalink)
-Manfred- Portal Member Join Date: May 2007 Posts: 103 Thanks: 4 Thanked 19 Times in 11 Posts Country:	I can confirm this. Long lines and last chars missing, quite annoying bug when scrolling EPG data. Please fix this. -M-