MediaPortal II gets opensource xaml skinengine

[bedlam]

heh, browsing through the code. got it to work and all. Nice work!
This confuses me though:
SkinEngine.Controls.Button inherits from Control
SkinEngine.Controls.Visual.Button inherits from Border(why not ContentControl?) which inherits from FrameWorkElement.

It´s the Visual Button that gets rendered right? But what does the other one do? And how are they connected?


It can be repeated again: great work!

[frodo]

You're right
Since a Button has a Template which defines how it should render itself
i think we can simple inherit Button from FrameWorkElement directly

[bedlam]

Originally Posted by frodo

You're right
Since a Button has a Template which defines how it should render itself
i think we can simple inherit Button from FrameWorkElement directly

But wouldn´t inheriting from FrameWorkElement disable some scenarios ?
Like this one:

   <StackPanel>
      <StackPanel.Resources>
         <ControlTemplate x:Key="MyButtStyle" TargetType="{x:Type Button}">
            <Border
               x:Name="PART_border"
               Background="SlateGray"
               BorderBrush="Black"
               BorderThickness="1"
               CornerRadius="5">
               <ContentPresenter/>
            </Border>
            <ControlTemplate.Triggers>
               <Trigger Property="IsMouseOver" Value="True">
                  <Setter TargetName="PART_border" Property="Background" Value="#FF8CB2BD"/>
               </Trigger>
               <Trigger Property="IsPressed" Value="True">
                  <Setter TargetName="PART_border" Property="Background" Value="#FF154451"/>
                  <Setter Property="Foreground" Value="White" />
               </Trigger>
            </ControlTemplate.Triggers>
         </ControlTemplate>
      </StackPanel.Resources>
      
      <Button  Width="100" Height="75" Template="{StaticResource MyButtStyle}">
         <Grid>
            <Grid.ColumnDefinitions>
               <ColumnDefinition/>
               <ColumnDefinition/>
            </Grid.ColumnDefinitions>
            <Image Grid.Column="0" Source="http://www.freeiconsweb.com/Freeicons/256x256_Transparent_Icons2/27.png"/>
            <TextBlock Grid.Column="1" VerticalAlignment="Center" Text="Home"/>
         </Grid>
      </Button>
      
      <Button  Width="100" Height="75" Template="{StaticResource MyButtStyle}">
         <Grid>
            <Grid.ColumnDefinitions>
               <ColumnDefinition/>
               <ColumnDefinition/>
            </Grid.ColumnDefinitions>
            <Image Grid.Column="0" Source="http://www.freeiconsweb.com/Freeicons/256x256_Transparent_Icons2/35.png"/>
            <TextBlock Grid.Column="1" VerticalAlignment="Center" Text="Away"/>
         </Grid>
      </Button>
   </StackPanel>

Both buttons use the same template but have different content. If they don´t inherit from ContentControl They would have had to have two templates, since the images differ between the Buttons?

Oooor I might just be tired....

Edit: Off course one could implement a new "Content" property. But in wpf there are quite many controls that derive from ContentControl such as ListViewItem, HeaderedItemsControl and so on. The later would be great for creating dialogs and such.

[frodo]

ok will fix this

[bedlam]

Are you skipping the whole Attached/DependencyProperty-thing or are you planning on another equally flexible system for "distributed" properties? And if you are skipping them, wouldn´t this be a deal-breaker? If someone wanted to implement a... RadialPanel after "v1". The developer would need to make changes into UIElement,adding a property such as "Angle". Which is kind of..wrong right? When instantiating a FrameWorkElement via XAML it should be able to register a property such as RadialPanel.Angle and add to its own internal collection of DependencyProperties. this would then result in the whole Get/SetValue()-deal which many new WPF developers have abit of a struggle with, but provide much of WPFs renowned flexibility, extensibility and layout.

But perhaps what I´ve seen is temporary code, It´s hard to know! Sorry if I´m abit "Submit Reply"-happy here but I´m just really psyched about this!

[infinityloop]

Originally Posted by bedlam

But perhaps what I´ve seen is temporary code, It´s hard to know!

the whole thing is WIP, means -> not finished.

just to let you know

[frodo]

Are you skipping the whole Attached/DependencyProperty-thing or are you planning on another equally flexible system for "distributed" properties?

As you see i've chosen a different approach
Yes we have dependency properties, but they are implemented differently from WPF
If someone wants to add a RadialPanel after v1.0, he can implement that class, derive it from FrameWorkElement
and put the dependency properties specific for this new RadialPanel in the RadialPanel class


Note that any new properties will be automaticly detected & handled
by the xaml parser. So without changing the core skinengine
you can add new controls and new dependency properties
to your own new controls

Frodo

[bedlam]

[quote=infinityloop]

just to let you know

You can consider me informed

Originally Posted by frodo

As you see i've chosen a different approach
Yes we have dependency properties, but they are implemented differently from WPF
If someone wants to add a RadialPanel after v1.0, he can implement that class, derive it from FrameWorkElement
and put the dependency properties specific for this new RadialPanel in the RadialPanel class

Note that any new properties will be automaticly detected & handled
by the xaml parser. So without changing the core skinengine
you can add new controls and new dependency properties
to your own new controls

Frodo

Ah! nice to hear, that should give me a hint to look at were that kind of magic happens
Even so, it still confuses me that UIElement has these kinds of properties defined: Dock, Row, Column, rowspan and so on. Well, I´ll just have to have a look at the xamlreader(or whatever it´s called) code then.

[m0deth]

Can I assume it's possible then to have both raster and vector elements as animated elements? and if so....both onscreen at the same time, and what sort of performance hit would that be.

you could pull off some amazing things with that kind of freedom.

[frodo]

Can I assume it's possible then to have both raster and vector elements as animated elements?

Yes that will work

and if so....both onscreen at the same time, and what sort of performance hit would that be.

That greatly depends
- on the GFX card you have, (the faster the better)
- the kind of animation(s)
- the resolution of the object you are animation
- the resolution you run MP-II (offcourse 720x576 will requires less CPU/GPU then 1920x1080)

However we do try to reach the same performance as WPF and better

Frodo