My Lyrics 0.21 - Comments and bug reporting

[tomtom21000]

Hi mackey,

it seems that from my 5.800 song collection ony 80 are missing lyrics. And that is a lot of non main-stream music. That´s great.

I rescanned all my songs (also previously marked songs)
Have a look at the screenshot. Shouldn´t it say 0 instead of 214?
Just a verrry small thing

tomtom

[cedric]

MP 0.2.2
Blue two
Lyrics 0.21

When I want to update a lyric in the configuration window, it starts to search lyrics and at the end the programm close with an error. I got the same in lyrics database and marked database.

Cédric

[tomtom21000]

Might be the same as cedrics report.

After running 0.21 without problems the first time on mp 0.2.2. + svn from today, the configuration program reported a windows error "configuration.exe has encountered a problem and has to be closed blahbla". The search of my lyrics ran further nevertheless. this happened twice. First run with the same settings as the succesful run and second only on previously marked songs.

If there are any logfiles that might help, please say so, then I´ll try to provide them.

tomtom

[Psycho Reptile]

mackey, when switching between basic and wide screens, artist, song, track, duration and playing next info does no dissapear when the progress and coverart does. Is this intentional? Nice work on the plugins so far .
->

[mackey]

Originally Posted by cedric

MP 0.2.2
Blue two
Lyrics 0.21

When I want to update a lyric in the configuration window, it starts to search lyrics and at the end the programm close with an error. I got the same in lyrics database and marked database.

Cédric

Okay. Thanks a lot for the report. There will be a fix for this in the next version.

[mackey]

Originally Posted by tomtom21000

Might be the same as cedrics report.

After running 0.21 without problems the first time on mp 0.2.2. + svn from today, the configuration program reported a windows error "configuration.exe has encountered a problem and has to be closed blahbla". The search of my lyrics ran further nevertheless. this happened twice. First run with the same settings as the succesful run and second only on previously marked songs.

If there are any logfiles that might help, please say so, then I´ll try to provide them.

tomtom

I'm not sure it is the same fault as cedric, so please send the logfiles if you are able to recreate the error. It might be a great help. Thanks. Until then I'll try to call the error myself in debug mode.

[mackey]

Originally Posted by Psycho Reptile

mackey, when switching between basic and wide screens, artist, song, track, duration and playing next info does no dissapear when the progress and coverart does. Is this intentional? Nice work on the plugins so far .
->

Yup, it is intentional. The newest version of the plugin only support BlueTwo and BlueTwo wide 100%, and they don't seek to please other skins than these.
In contrast to Replicant, it makes sense to leave those controls in wide mode, so the code will always have them there. However, if you make your great skin fit for the new looks of MyLyrics, I will come up with something to add/remove controls based on the currently used skin. In that way the skin supports the plugin, and the plugin supports the skin.

Update: I see from your last revision that you already supports v. 0.21. Cool I will work something out as promised.

[mackey]

Originally Posted by tomtom21000

Hi mackey,

it seems that from my 5.800 song collection ony 80 are missing lyrics. And that is a lot of non main-stream music. That´s great.

I rescanned all my songs (also previously marked songs)
Have a look at the screenshot. Shouldn´t it say 0 instead of 214?
Just a verrry small thing

tomtom

Until now I have considered the Songs to search value as a static value, but hey! You got a good point! Why not make it dynamic count down. It is in the next release. thanks

[tomtom21000]

Hi mackey,

did some extensive testing this morning on the plugin.

Crashes of the lyrics search:

First time this morning the search went through without crash.
After that, I got constantly windows exeptions for configuration.exe (while lyrics search seemed to continue)
Once I had a cpu load of 100%.
There is absolutely nothing in any log about the crash
(searched mylyrics.log/mylyricsbatch.log/configuration.log)
Once I "managed" to produce an "unhandled exeption" of the plugin after the windows exception notification came up. Still nothing in any of the logs.
The search was started with the default options or only on marked songs. It also crashed on searching a lyric for a single song from the marked database.
Also deleted the marked database. Made no difference.

no lyrics change on song change

can confirm that lyrics don´t change here on song change, as reported by others. Album and artist pictures aren´t updated either.
When you leave the lyricsscreen and reenter, everything is updated.
Using B2 4:3, scrobble on

Edit: Seems to be more complicated. I have seen three behaviours:

# no song lyrics and cover-art update on song change (most of the time)
# display: " no song is playing" (but there is) (on some songs)
# changing lyrics as it should (seen once only)

search stats

I would have sworn that the song search count was dynamic.

I somewhat focused on this and the more I investigated, the stranger the stats became.

My setup: my music database holds 5,985 thorougly tagged songs.
The mylyrics database says it has lyrics for 5,661 songs.
I estimate, that 3,000-4,000 mp3s have lyrics inside their tags.

Now 5,985 - 5,661 = 324 songs without lyrics.
A search with the default options gives:

Total songs: 5,985
Songs with lyrics: 5,750
Songs with mark: 89
Songs to search: 0
Disregarded: 59

1)
Accidently I reran this search which I only had performed the other day, so that "songs nto search" 0 was correct.
--> 5,750 > 5,661
Just realizing while writing this, that 5,661 + 89 = 5,750.
Q: Shouldn´t be there 324 marked songs (or 324-59)
Q: If songs for which no lyrics could be found get marked, they can´t be counted for "songs with lyrics", can they?


2)
After this I unchecked "disregard previously marked songs". This gave me these stats:

Total songs: 5,985
Songs with lyrics: 5,742
Songs with mark: 97
Songs to search:
Disregarded: 59

There is a delta of 8 songs (5,750/5,742 and 89/97)


3)
Now I changed to marked only
(cannot remember if 2) found additional lyrics)

this showed now 113 songs to search
the search found a lot of lyric
it marked 36, found 60 and the search stopped at these 96 songs, it did not finish and never reached the 113. I stopped it manually.

4)
I deleted the marked database

Total songs: 5,985
Songs with lyrics: 5,742
Songs with mark: 0
Songs to search: 20
Disregarded: 59

-> it only showed 20 songs to search (Crashed a couple of times)

5)
Disregarded songs

This was a constant figure: it was allways 59.
According to the options, this number should contain
"Disregard songs with lyrics in database"
"Disregard songs with lyrics in mp3"
and "Disregard songs by "various artists"

as stated the lyrics database says it contains 5,661 lyrics,
3,000-4,000 of my mp3´s contain lyrics in the tags
According to MP artist view, I have not one song by "various artists"
--> either it should be 5,661
--> or label should be "disregarded songs by "various artists"
--> still no clue where the 59 count in my case comes from.

Mackey, this is all not really important, the functionality is the important thing and this is excellent. But I am a bit of a statistics freak
Maybe this helps to narrow the issues down. If I can check anything else for you, give me a yell.

tomtom

[Psycho Reptile]

Originally Posted by mackey

Update: I see from your last revision that you already supports v. 0.21. Cool I will work something out as promised.

Sweet, I based the skin file on your B2 wide version. I could reposition the controls to better suit the "disappearing act" . Alternatively if it was an option in config to hide that group of controls that would be good too .