home
products
contribute
download
documentation
forum
Home
Forums
New posts
Search forums
What's new
New posts
All posts
Latest activity
Members
Registered members
Current visitors
Donate
Log in
Register
What's new
Search
Search
Search titles only
By:
New posts
Search forums
Search titles only
By:
Menu
Log in
Register
Navigation
Install the app
Install
More options
Contact us
Close Menu
Forums
MediaPortal 1
Support
General Support
Music Player issues
Contact us
RSS
JavaScript is disabled. For a better experience, please enable JavaScript in your browser before proceeding.
You are using an out of date browser. It may not display this or other websites correctly.
You should upgrade or use an
alternative browser
.
Reply to thread
Message
<blockquote data-quote="Pablik" data-source="post: 1291581" data-attributes="member: 106554"><p>Version: MediaPortal 1.30</p><p></p><p>Issue 1:</p><p>At the end of a playback (when the last item of playlist ends), the player is not properly stopped. If you try to play another item the MP freezes completly.</p><p></p><p>Condition:</p><p>- minidisplay is rendering EQ</p><p></p><p>Source of the issue:</p><ul> <li data-xf-list-type="ul">Core\MusicPlayer\BASS\BassAudioEngine.cs</li> <li data-xf-list-type="ul">public int GetChannelData(int handle, float[] buffer, int lenght)</li> </ul><p></p><p>Description:</p><p>The problem is that method Bass.BASS_ChannelGetData is executed under lock _syncRoot. For some reason the call of Bass.BASS_ChannelGetData is not beeing returned when the playlist ends. This causes not to release _syncRoot lock and blocks execution of Stop() method which is under the same lock (called from OnMusicStreamMessage).</p><p>Removing the lock syntax fixes the issue. I'm not sure if the lock is actually needed for this method.</p><p></p><p></p><p>Issue 2:</p><p>If the playlist includes playlist file(like m3u) then start of the playback is made from wrong facade item.</p><p></p><p>Condition:</p><p>-playlist includes m3u file</p><p></p><p>Source of the issue:</p><ul> <li data-xf-list-type="ul">WindowPlugins\Common.GUIPlugins\Music\GUIMusicBaseWindow.cs</li> <li data-xf-list-type="ul">protected void AddItemsToCurrentPlaylist(List<PlayListItem> pItems, bool clearPlaylist, bool addAllTracks)</li> </ul><p></p><p>Description:</p><p>The problem is if the m3u playlist item is actually behind selected facade item in the list. In this case the var playlistcount shall not to be incremented.</p></blockquote><p></p>
[QUOTE="Pablik, post: 1291581, member: 106554"] Version: MediaPortal 1.30 Issue 1: At the end of a playback (when the last item of playlist ends), the player is not properly stopped. If you try to play another item the MP freezes completly. Condition: - minidisplay is rendering EQ Source of the issue: [LIST] [*]Core\MusicPlayer\BASS\BassAudioEngine.cs [*]public int GetChannelData(int handle, float[] buffer, int lenght) [/LIST] Description: The problem is that method Bass.BASS_ChannelGetData is executed under lock _syncRoot. For some reason the call of Bass.BASS_ChannelGetData is not beeing returned when the playlist ends. This causes not to release _syncRoot lock and blocks execution of Stop() method which is under the same lock (called from OnMusicStreamMessage). Removing the lock syntax fixes the issue. I'm not sure if the lock is actually needed for this method. Issue 2: If the playlist includes playlist file(like m3u) then start of the playback is made from wrong facade item. Condition: -playlist includes m3u file Source of the issue: [LIST] [*]WindowPlugins\Common.GUIPlugins\Music\GUIMusicBaseWindow.cs [*]protected void AddItemsToCurrentPlaylist(List<PlayListItem> pItems, bool clearPlaylist, bool addAllTracks) [/LIST] Description: The problem is if the m3u playlist item is actually behind selected facade item in the list. In this case the var playlistcount shall not to be incremented. [/QUOTE]
Insert quotes…
Verification
Post reply
Forums
MediaPortal 1
Support
General Support
Music Player issues
Contact us
RSS
Top
Bottom