[TV] North American Closed Captions (1 Viewer)

Sebastiii

Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    I've pushed some changes which should fix the Debug build problems (I hope ;))

    Thanks :)

    It works from VS :) Need to add project dependencies to BaseClasses. But it failed to build from batch (Release or Debug) :)
    upload_2015-2-11_15-23-53.png
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    Good, i was able to turn on CC on start :) but i think it will override other subtible if present.
    For example, if a stream has CC + Teletext + DVB subtitle, if CC option in MP config is checked, CC will be use by default but we can select another subtitle manually.

    Need testing about this change done in core.dll :)
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    Hmmm that will not work correctly, because Core CC Parser is added on graph (needed for now because we can't know if the stream has CC or not).
    So it's mean that even if a TVstream doesn't have CC stream, CC will be selected by default. I think it needed a more deep rework to fix that. (Like TsReader tell us if CC are in stream and then add/authorise Core CC parser to be added or not. lol
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    Maybe i have something finally :)
    Will push the change in my build for now and create a patch :)
     

    Attachments

    • 0001-Fork-Enable-CC-if-AutoTurnon-Option-is-activated-and.patch
      1.5 KB

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    I will build a full special build with all change if someone want to try but this will not be an official one (only the one i use @ home).
    But it will be better to test only change againt 1.10 :)
     

    Users who are viewing this thread

    Top Bottom