0003047: GUITextureManager deadlock (1 Viewer)

[MediaPortal-Bot]

From armandp words:

"Current 1.1.0 has a potential deadlock issue when multihreading which is caused by the dispose logic of the GUIImage class.
What can happen is that when an GUIImage is disposed of in a seperate thread and the main thread is handling the same GUIImage the GUI just locks up."

http://mantis.team-mediaportal.com/view.php?id=3047

Open the issue in Mantis...

 

[mironicus]

AW: 0003047: GUITextureManager deadlock

The commited change slows down the Mediaportal GUI for me. I have some strange behaviour with the Black Glass Skin.

1. Start Full Screen TV
2. Press the Home key to go back to the Basic Home screen.

= The TV picture freezes for 4-5 seconds before the Basic Home Menu appears. Also the whole responsiveness of Mediaportal is slightly slower.

This behaviour does not happen with the Default Blue3Wide Skin.

If I compile Mediaportal without this change it runs fine and smooth again.

 

[catavolt]

AW: 0003047: GUITextureManager deadlock

As I never experienced a deadlock, I can´t say if this patch works as it should. But I also experienced a small delay in my skins when going back to basic home (due to multiimages?)

 

[mironicus]

AW: 0003047: GUITextureManager deadlock

It depends on the skin. Black Glass is full of Multi-Images and animations.

Also interesting: I have some Full HD-cartoons (Anime) with animated subtitles. I am always using the highest resolution for the subtitles. The svn changes stresses my GPU so much that it causes dropped frames with the subtitles enabled! I had to lower the resolution of the subtitles to medium to fix this.

The video plays smoothly with the subtitle resolution set to high if I disable this patch.

 

[catavolt]

AW: 0003047: GUITextureManager deadlock

After testing a bit more I found out, that visibility checks are extremely slow. It happens very often that a screen shows items that should not been shown because of a visibility condition. These items disappear after half a second. This is a bit annoying, especially in TVSeries, MovingPictures, HTPC Info etc. were items depend a lot on special visibility conditions.
Maybe we should ask to improve the change or even to revert it (as I said before never experienced a deadlock).

 

[armandp]

i will look into the claims.. i expect the changes to slightly slow down some parts (because of the thread safety) but not that it would cause this much of an impact. If i can't find the culprit i can just do a simple better lock on the release mechanism and revert the other changes.

 

[elliottmc]

Hi,

I see that the latest commit for this (26456) is only in trunk, while other fixes are in 1.1.1 branch. Is this deliberate?

Mark

 

[Deda]

Just to add also one small observation, in movie info screen within My Videos, cover change with up or down arrow doesn't change cover preview anymore. Default one stays until refreshing share or database view.
Without deadlock patch it works ok. if you can look into it.

 

[armandp]

Currently i'm thinking of just reverting the changes and reopen #3047 - i don't think the slowdowns and such weigh up against the occasional deadlock (tho that is ofcourse a showstopper by itself). I think the deadlock can be solved more easily and i want to back away from the other changes until i figure this out

 

[mironicus]

AW: 0003047: GUITextureManager deadlock

Too late. Mediaportal 1.1.1 has been released today and mantis 3047 is included.