[fixed] 1.2 Beta Coverflow Bug? (1 Viewer)

h4rd

Portal Member
October 29, 2008
24
0
Hamburg
MediaPortal Version: 1.2 Beta
MediaPortal Skin: Streamed MP
Windows Version: win7 64
CPU Type: phenom II x4 965
SSD: OCZ Vertex 2


Hi,
i have a navigation problem with the coverflow view.
I am using a dinovo mini as remote, so i have to remapp the "previous menu button" (ESC on default) to the backspace button.

In the old filmstrip view everything behaves normal, but when i use the coverflow view , pushing the button brings me back to the previous menu but always to the beginning of the directory.
So imagine u have many music albums in one directory, u have to scroll back every time.

i hope u understand my problem ...

To reproduce, just map the backspace button to "previous menu" and try to navigate throug coverflow folders :D

btw, the Coverflow in Movingpictures working without this problem!


greetz Björn
 

Attachments

jameson_uk

Retired Team Member
  • Premium Supporter
  • January 27, 2005
    7,258
    2,528
    Birmingham
    United Kingdom United Kingdom
    Country flag
    So am I right in thinking that you are saying that when you go back it takes you to the first item in the list not the one you selected?

    is this just within music or does the same happen within video plugin?
    if music is this in shares or database views?

    are you sure this only happens with coverflow and does not happen also with filmstrip in 1.2 ?
     

    SilentException

    Retired Team Member
  • Premium Supporter
  • October 27, 2008
    2,617
    1,130
    Rijeka, Croatia
    Croatia Croatia
    Country flag
    This cause for this is in GUIFacadeViewControl.cs, SelectedListItemIndex property setter. It is missing setting of the selected item index for Filmstrip and CoverFlow :)
     

    jameson_uk

    Retired Team Member
  • Premium Supporter
  • January 27, 2005
    7,258
    2,528
    Birmingham
    United Kingdom United Kingdom
    Country flag
    This cause for this is in GUIFacadeViewControl.cs, SelectedListItemIndex property setter. It is missing setting of the selected item index for Filmstrip and CoverFlow :)
    That would do it :p

    You fixed it yet then? ;)

    Edit: Is this the issue? There is no direct call but instead we use
    Code:
     GUIControl.SelectItemControl(GetID, facadeLayout.GetID, iItem);
    which fires a
    Code:
    GUI_MSG_ITEM_SELECT
    message which is handled in CoverFlow.cs and I had a quick scan through the code but could not find the setter being called?
     

    h4rd

    Portal Member
    October 29, 2008
    24
    0
    Hamburg
    AW: Re: 1.2 Beta Coverflow Bug?

    So am I right in thinking that you are saying that when you go back it takes you to the first item in the list not the one you selected?


    is this just within music or does the same happen within video plugin?
    if music is this in shares or database views?

    are you sure this only happens with coverflow and does not happen also with filmstrip in 1.2 ?
    yes, it takes me back to the first item.

    It happens in the video and picture plugins, too.

    I think it is in shares view!?

    It happens only in Coverflow view.
    Filmstrip and List view working normally.

    I notice the this Problem in 1.2 Alpha the first time.


    thx guys, i hope you can fix it or give or tell what to do :D
     

    jameson_uk

    Retired Team Member
  • Premium Supporter
  • January 27, 2005
    7,258
    2,528
    Birmingham
    United Kingdom United Kingdom
    Country flag
    odd very odd...... it seems backspace is always mapped to select first item even though that is not configured in the keyboard mapping and only in coverflow :confused:

    Just use backspace in coverflow with default mappings (backspace is not mapped anywhere) and it will jump to first item. Do it in any other layout and it does nothing...
     

    jameson_uk

    Retired Team Member
  • Premium Supporter
  • January 27, 2005
    7,258
    2,528
    Birmingham
    United Kingdom United Kingdom
    Country flag
    It is a Bug, isn t it?
    It would appear so. I can't see any reason why this would be expected behavior. That said I have not had chance to look through the code and was hoping silentex had figured it out by know and could say whether it was a bug or by design ;)

    I will see if I get a spare 20 minutes to look into this over the weekend
     

    SilentException

    Retired Team Member
  • Premium Supporter
  • October 27, 2008
    2,617
    1,130
    Rijeka, Croatia
    Croatia Croatia
    Country flag
    Yes it's a bug. Both Filmstrip and CoverFlow didn't implement one of the facade methods for setting focus. They however had implementation for focus on GUI message. So depending on the plugin code, focus was set correctly for some plugins and not for others.

    I've fixed it. Any mantis?
     

    elliottmc

    Retired Team Member
  • Premium Supporter
  • August 7, 2005
    14,927
    6,061
    Cardiff, UK
    United Kingdom United Kingdom
    Country flag
    Yes it's a bug. Both Filmstrip and CoverFlow didn't implement one of the facade methods for setting focus. They however had implementation for focus on GUI message. So depending on the plugin code, focus was set correctly for some plugins and not for others.

    I've fixed it. Any mantis?
    Not yet!

    Mark
     

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    Top Bottom