Reply to thread

Message

<blockquote data-quote="vapourEyes" data-source="post: 1305481" data-attributes="member: 143065">I found, eventually its best to introduce a Thread to handle the Pause and enable VideoBuffer to stay intact.Its much more reliable and tested working here. Apologies again for not completing a PR and Merging that way.The new thread code is below, within TvHome.cs:[CODE=csharp]&nbsp; &nbsp; static void afterChannelChangePause()&nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; Thread.Sleep(10000);&nbsp; &nbsp; &nbsp; g_Player.Pause();&nbsp; &nbsp; }[/CODE]This is the code for the Notify() handler, within TvHome.cs[CODE=csharp]&nbsp; &nbsp; &nbsp; &nbsp; case GUIMessage.MessageType.GUI_MSG_NOTIFY_TV_PROGRAM:&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; bool wasPaused = g_Player.Paused;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; TVNotifyYesNoDialog tvNotifyDlg = (TVNotifyYesNoDialog)GUIWindowManager.GetWindow((int)GUIWindow.Window.WINDOW_DIALOG_TVNOTIFYYESNO);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; TVProgramDescription notify = message.Object as TVProgramDescription;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (tvNotifyDlg == null || notify == null)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; int minUntilStart = _preNotifyConfig / 60;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (notify.StartTime &gt; DateTime.Now)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (minUntilStart &gt; 1)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; tvNotifyDlg.SetHeading(String.Format(GUILocalizeStrings.Get(1018), minUntilStart));&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; else&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; tvNotifyDlg.SetHeading(1019); // Program is about to begin&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; else&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; tvNotifyDlg.SetHeading(String.Format(GUILocalizeStrings.Get(1206), (DateTime.Now - notify.StartTime).Minutes.ToString()));&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; tvNotifyDlg.SetLine(1, notify.Title);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; tvNotifyDlg.SetLine(2, notify.Description);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; tvNotifyDlg.SetLine(4, String.Format(GUILocalizeStrings.Get(1207), notify.Channel.DisplayName));&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Channel c = notify.Channel;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; string strLogo = string.Empty;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (c.IsTv)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; strLogo = MediaPortal.Util.Utils.GetCoverArt(Thumbs.TVChannel, c.DisplayName);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; else if (c.IsRadio)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; strLogo = MediaPortal.Util.Utils.GetCoverArt(Thumbs.Radio, c.DisplayName);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; tvNotifyDlg.SetImage(strLogo);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; tvNotifyDlg.TimeOut = _notifyTVTimeout;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (_playNotifyBeep)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; MediaPortal.Util.Utils.PlaySound(&quot;notify.wav&quot;, false, true);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; tvNotifyDlg.SetDefaultToYes(_changeChannelOnNotifyTimeout);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; tvNotifyDlg.DoModal(GUIWindowManager.ActiveWindow);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (tvNotifyDlg.IsConfirmed)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; try&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; //MediaPortal.Player.g_Player.Stop();&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (c.IsTv)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; MediaPortal.GUI.Library.GUIWindowManager.ActivateWindow((int)MediaPortal.GUI.Library.GUIWindow.Window.WINDOW_TV);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; g_Player.ShowFullScreenWindow();&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; TVHome.ViewChannelAndCheck(c);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; //if (TVHome.Card.IsTimeShifting &amp;&amp; TVHome.Card.IdChannel == c.IdChannel)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; //{&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; //&nbsp; g_Player.ShowFullScreenWindow();&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; //}&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; else if (c.IsRadio)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; MediaPortal.GUI.Library.GUIWindowManager.ActivateWindow((int)MediaPortal.GUI.Library.GUIWindow.Window.WINDOW_RADIO);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Radio.CurrentChannel = c;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Radio.Play();&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (wasPaused)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Thread afterChannelChangePauseThread = new Thread(afterChannelChangePause);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; afterChannelChangePauseThread.Start();&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; catch (Exception e)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Log.Error(&quot;TVHome: TVNotification: Error on starting channel {0} after notification: {1} {2} {3}&quot;, notify.Channel.DisplayName, e.Message, e.Source, e.StackTrace);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; break;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; }[/CODE]</blockquote>

[QUOTE="vapourEyes, post: 1305481, member: 143065"] I found, eventually its best to introduce a Thread to handle the Pause and enable VideoBuffer to stay intact. Its much more reliable and tested working here. Apologies again for not completing a PR and Merging that way. The new thread code is below, within TvHome.cs: [CODE=csharp] static void afterChannelChangePause() { Thread.Sleep(10000); g_Player.Pause(); }[/CODE] This is the code for the Notify() handler, within TvHome.cs [CODE=csharp] case GUIMessage.MessageType.GUI_MSG_NOTIFY_TV_PROGRAM: { bool wasPaused = g_Player.Paused; TVNotifyYesNoDialog tvNotifyDlg = (TVNotifyYesNoDialog)GUIWindowManager.GetWindow((int)GUIWindow.Window.WINDOW_DIALOG_TVNOTIFYYESNO); TVProgramDescription notify = message.Object as TVProgramDescription; if (tvNotifyDlg == null || notify == null) { return; } int minUntilStart = _preNotifyConfig / 60; if (notify.StartTime > DateTime.Now) { if (minUntilStart > 1) { tvNotifyDlg.SetHeading(String.Format(GUILocalizeStrings.Get(1018), minUntilStart)); } else { tvNotifyDlg.SetHeading(1019); // Program is about to begin } } else { tvNotifyDlg.SetHeading(String.Format(GUILocalizeStrings.Get(1206), (DateTime.Now - notify.StartTime).Minutes.ToString())); } tvNotifyDlg.SetLine(1, notify.Title); tvNotifyDlg.SetLine(2, notify.Description); tvNotifyDlg.SetLine(4, String.Format(GUILocalizeStrings.Get(1207), notify.Channel.DisplayName)); Channel c = notify.Channel; string strLogo = string.Empty; if (c.IsTv) { strLogo = MediaPortal.Util.Utils.GetCoverArt(Thumbs.TVChannel, c.DisplayName); } else if (c.IsRadio) { strLogo = MediaPortal.Util.Utils.GetCoverArt(Thumbs.Radio, c.DisplayName); } tvNotifyDlg.SetImage(strLogo); tvNotifyDlg.TimeOut = _notifyTVTimeout; if (_playNotifyBeep) { MediaPortal.Util.Utils.PlaySound("notify.wav", false, true); } tvNotifyDlg.SetDefaultToYes(_changeChannelOnNotifyTimeout); tvNotifyDlg.DoModal(GUIWindowManager.ActiveWindow); if (tvNotifyDlg.IsConfirmed) { try { //MediaPortal.Player.g_Player.Stop(); if (c.IsTv) { MediaPortal.GUI.Library.GUIWindowManager.ActivateWindow((int)MediaPortal.GUI.Library.GUIWindow.Window.WINDOW_TV); g_Player.ShowFullScreenWindow(); TVHome.ViewChannelAndCheck(c); //if (TVHome.Card.IsTimeShifting && TVHome.Card.IdChannel == c.IdChannel) //{ // g_Player.ShowFullScreenWindow(); //} } else if (c.IsRadio) { MediaPortal.GUI.Library.GUIWindowManager.ActivateWindow((int)MediaPortal.GUI.Library.GUIWindow.Window.WINDOW_RADIO); Radio.CurrentChannel = c; Radio.Play(); } if (wasPaused) { Thread afterChannelChangePauseThread = new Thread(afterChannelChangePause); afterChannelChangePauseThread.Start(); } } catch (Exception e) { Log.Error("TVHome: TVNotification: Error on starting channel {0} after notification: {1} {2} {3}", notify.Channel.DisplayName, e.Message, e.Source, e.StackTrace); } } break; } } [/CODE] [/QUOTE]

Verification