[Approved] - ajp8164 patch rollup against 23209

Discussion in 'Archive' started by ajp8164, August 12, 2009.

  1. ajp8164

    ajp8164 Portal Pro

    Joined:
    January 9, 2008
    Messages:
    575
    Likes Received:
    583
    Gender:
    Male
    Occupation:
    Consulting Software Engineer
    Location:
    Atlanta, GA
    Ratings:
    +584 / 0
    Home Country:
    United States of America United States of America
    Show System Specs
    EDIT: I added the following two attachments and removed one attachment. Apply the fp1 (fixpack1) patch on top of the original (it's an incremental patch and only contains diffs for two source files). Simply replace the GUISpinButton implementation with the attached fp1 version.

    Added attachments: GUISpinButton_fp1.cs, all_changes_patch_fp1.patch
    Removed attachments: GUISpinButton.cs

    Changes:
    • Fixed a bug in the CheckButton that prevented correct detection of the control being selected (or not).
    • Added SpinButton x,y "spin text" offset allowing for fine tuning the text position of the value of the control.
    • Fixed bug in event handling of SpinButton.
    • Fixed inadvertent changes in GUILabelControl that broke the TvPlugin.
    -------

    Mr Hipp (and all),

    Attached is a roll up of all of my pending/incorporated patches since 23209 plus a few more as noted below. This patch can be applied against 23209 to get all of the changes in one shot :D

    This roll up contains these pending/incorporated patches:

    https://forum.team-mediaportal.com/submit-patches-mediaportal-tv-server-etc-325/guicheckbutton-implementation-68867/
    https://forum.team-mediaportal.com/submit-patches-mediaportal-tv-server-etc-325/vertical-text-alignment-new-feature-68706/
    https://forum.team-mediaportal.com/submit-patches-mediaportal-tv-server-etc-325/fadelabel-text-wrapping-button-control-fadelabel-new-features-67893/
    https://forum.team-mediaportal.com/submit-patches-mediaportal-tv-server-etc-325/keeplook-new-gui-feature-68601/
    https://forum.team-mediaportal.com/submit-patches-mediaportal-tv-server-etc-325/borders-your-images-buttons-new-feature-68447/
    https://forum.team-mediaportal.com/submit-patches-mediaportal-tv-server-etc-325/fadelabel-text-clip-fix-68547/
    https://forum.team-mediaportal.com/submit-patches-mediaportal-tv-server-etc-325/shadow-text-new-feature-67695/

    This roll up also contains patches for the following items:

    1. fade label button fix - fixes a problem with my patch incorrectly adding the wrap string when scrolling is not necessary.
    2. label shadow fix - fixes a problem with detection of whether or not a shadow should be drawn (fix is more efficient than orig impl).
    3. spin button control (new) - adds a new control similar to updownbutton but with different styling options and behavior (different enough that I really needed a new control). Will post complete description later - for now, have a look at the attached source code and the attached picture ;-)

    [​IMG]

    Hope this helps in bringing all this work to the benefit of others. Thanks to all for your help! :D



    -Andy
     

    Attached Files:

    • Like Like x 1
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. CHli

    CHli Portal Pro

    Joined:
    July 5, 2005
    Messages:
    1,251
    Likes Received:
    14
    Occupation:
    Embedded Software Engineer
    Location:
    Switzerland
    Ratings:
    +14 / 0
    Home Country:
    Switzerland Switzerland
    That's quite a reasonable amount of work ! Thank you !
     
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!