[Approved] allowhiddenfocus on visible skin tag (1 Viewer)

ajp8164

Portal Pro
January 9, 2008
575
1,166
Atlanta, GA
Home Country
United States of America United States of America
I found that allowhiddenfocus as described in the documentation was not functioning as advertised. In looking at the implementation I found that it was simply not complete; there where two items to address:

(1) the skin xml node attribute (allowhiddenfocus="true") was never read from the skin xml file and stored in the control object

(2) the logic for testing whether or not the control should grab focus (even when not visible, and then forcing visibility) was flawed.

I managed to correct each of these items and tested with some skin development I am working on. I tested with button controls and it appears to work great. I also browsed around the Blue3 skin to smoke test the change. Nothing appears broken... so far.

The patch affects GUIControl.cs and GUIControlFactory.cs in the Core.dll.
 

Attachments

  • allowhiddenfocus.patch
    30.7 KB

pilehave

Community Skin Designer
  • Premium Supporter
  • April 2, 2008
    2,566
    521
    Hornslet
    Home Country
    Denmark Denmark
    As mentioned in another thread, I also tested this patch and it seems to work perfectly :)
     

    Users who are viewing this thread

    Top Bottom