[Approved] - allowhiddenfocus on visible skin tag

Discussion in 'Archive' started by ajp8164, July 9, 2009.

  1. ajp8164

    ajp8164 Portal Pro

    Joined:
    January 9, 2008
    Messages:
    575
    Likes Received:
    583
    Gender:
    Male
    Occupation:
    Consulting Software Engineer
    Location:
    Atlanta, GA
    Ratings:
    +584 / 0
    Home Country:
    United States of America United States of America
    Show System Specs
    I found that allowhiddenfocus as described in the documentation was not functioning as advertised. In looking at the implementation I found that it was simply not complete; there where two items to address:

    (1) the skin xml node attribute (allowhiddenfocus="true") was never read from the skin xml file and stored in the control object

    (2) the logic for testing whether or not the control should grab focus (even when not visible, and then forcing visibility) was flawed.

    I managed to correct each of these items and tested with some skin development I am working on. I tested with button controls and it appears to work great. I also browsed around the Blue3 skin to smoke test the change. Nothing appears broken... so far.



    The patch affects GUIControl.cs and GUIControlFactory.cs in the Core.dll.
     

    Attached Files:

  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. pilehave
    • Premium Supporter

    pilehave Community Skin Designer

    Joined:
    April 2, 2008
    Messages:
    2,566
    Likes Received:
    500
    Gender:
    Male
    Occupation:
    Technical consultant, marketing
    Location:
    Hornslet
    Ratings:
    +517 / 0
    Home Country:
    Denmark Denmark
    As mentioned in another thread, I also tested this patch and it seems to work perfectly :)
     
  4. -Manfred-
    • Premium Supporter

    -Manfred- Retired Team Member

    Joined:
    May 15, 2007
    Messages:
    728
    Likes Received:
    341
    Ratings:
    +350 / 0
    Home Country:
    Finland Finland
    Added to SVN, thanks!
     
    • Like Like x 1
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!