Reply to thread

Message

<blockquote data-quote="Anthrax" data-source="post: 767806" data-attributes="member: 46494">AW: Audio Renderer ChangerHello Thor2605 and everybody,first off my chest: nice plugin, simple, clean, focussed on a single purpose and just works as advertised ;-) <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite8" alt=":D" title="Big Grin&nbsp; &nbsp; :D" loading="lazy" data-shortname=":D" />One thing I'd like to suggest though would be the use of configurable MediaPortal Actions... (I'd even contribute on the code if your time is limited)This would make it easier for everyone with a (MCE) Remote to assign a button for your plugin.Just a few things would be needed in order to incorporate this functionality:1. override OnAction() and check for the user configured Action:[CODE] [pseudo code]public override void OnAction(MediaPortal.GUI.Library.Action action){&nbsp; &nbsp;&nbsp; if (action == Settings.ConfiguredAction){&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; SwitchAudioRenderer(); //your switching magic here ;-)&nbsp; &nbsp;&nbsp; }else{&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; base.OnAction(action);&nbsp; &nbsp;&nbsp; }}[/CODE]2. Just add a ComboBox containing the values from the MediaPortal.GUI.Library.Action enumeration and let the user pick one3. we are done ;-)The Action enumeration can be found here: <a href="http://sources.team-mediaportal.com/websvn/filedetails.php?repname=MediaPortal&amp;path=%2Ftrunk%2Fmediaportal%2FCore%2Fguilib%2FAction.cs&amp;sc=1" target="_blank">WebSVN - MediaPortal - Rev 28022 - /trunk/mediaportal/Core/guilib/Action.cs</a>There are a lot of actions in there and everybody should be able to pick one which wouldn't be used otherwise like:ACTION_TOGGLE_MUSIC_GAP = 9886which I use for the MySleepTimer...please let me know if you even consider thinking about it and if I could help you out with anything.cheers mates,AnthraxPS: I've done the same in the MySleepTimer plugin if you you want to have look: <a href="http://mp-plugins.svn.sourceforge.net/viewvc/mp-plugins/trunk/plugins/MySleepTimer/MySleepTimer/" target="_blank">http://mp-plugins.svn.sourceforge.net/viewvc/mp-plugins/trunk/plugins/MySleepTimer/MySleepTimer/</a> (but remember this was my first plugin so don't expect any best practices in there!!!) ;-)</blockquote>

[QUOTE="Anthrax, post: 767806, member: 46494"] [b]AW: Audio Renderer Changer[/b] Hello Thor2605 and everybody, first off my chest: nice plugin, simple, clean, focussed on a single purpose and just works as advertised ;-) :thx: One thing I'd like to suggest though would be the use of configurable MediaPortal Actions... (I'd even contribute on the code if your time is limited) This would make it easier for everyone with a (MCE) Remote to assign a button for your plugin. Just a few things would be needed in order to incorporate this functionality: 1. override OnAction() and check for the user configured Action: [CODE] [pseudo code] public override void OnAction(MediaPortal.GUI.Library.Action action){ if (action == Settings.ConfiguredAction){ SwitchAudioRenderer(); //your switching magic here ;-) }else{ base.OnAction(action); } }[/CODE] 2. Just add a ComboBox containing the values from the MediaPortal.GUI.Library.Action enumeration and let the user pick one 3. we are done ;-) The Action enumeration can be found here: [url=http://sources.team-mediaportal.com/websvn/filedetails.php?repname=MediaPortal&path=%2Ftrunk%2Fmediaportal%2FCore%2Fguilib%2FAction.cs&sc=1]WebSVN - MediaPortal - Rev 28022 - /trunk/mediaportal/Core/guilib/Action.cs[/url] There are a lot of actions in there and everybody should be able to pick one which wouldn't be used otherwise like: [INDENT]ACTION_TOGGLE_MUSIC_GAP = 9886[/INDENT] which I use for the MySleepTimer... please let me know if you even consider thinking about it and if I could help you out with anything. cheers mates, Anthrax PS: I've done the same in the MySleepTimer plugin if you you want to have look: [url]http://mp-plugins.svn.sourceforge.net/viewvc/mp-plugins/trunk/plugins/MySleepTimer/MySleepTimer/[/url] (but remember this was my first plugin so don't expect any best practices in there!!!) ;-) [/QUOTE]

Verification