Reply to thread

Message

<blockquote data-quote="zombiepig" data-source="post: 85459" data-attributes="member: 12049">Hey rtv - i think i've tracked down the problem with missing artist images.In GUIMusicPlayingNow.cs:function UpdateTrackInfo()&nbsp; has the lines:[CODE]if (CurrentTrackTag.Artist != PreviousTrackTag.Artist)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; UpdateArtistInfo();[/CODE]So - if the artist is different to the last artist played, it runs UpdateArtistInfo, starts the ArtistInfoRequest thread, and then runs OnUpdateArtistInfoCompleted when the thread is complete. OnUpdateArtistInfoCompleted handles the actual adding of artist art to the viz window:[CODE]CurrentThumbFileName = Util.Utils.GetCoverArtName(Thumbs.MusicArtists, Util.Utils.FilterFileName(CurrentTrackTag.Artist));&nbsp; &nbsp; &nbsp; &nbsp; if (CurrentThumbFileName.Length &gt; 0)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; AddImageToImagePathContainer(CurrentThumbFileName);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; UpdateImagePathContainer();&nbsp; &nbsp; &nbsp; &nbsp; }[/CODE]Catch is, if the same artist is played twice in a row, UpdateArtistInfo will never be called and the artist thumbnail is not added to the container.The code in UpdateTrackInfo()&nbsp; should be something like:[CODE]if (CurrentTrackTag.Artist != PreviousTrackTag.Artist)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; UpdateArtistInfo();else {&nbsp;&nbsp; CurrentThumbFileName = Util.Utils.GetCoverArtName(Thumbs.MusicArtists,&nbsp; &nbsp; &nbsp; Util.Utils.FilterFileName(CurrentTrackTag.Artist));&nbsp; &nbsp; &nbsp; &nbsp; if (CurrentThumbFileName.Length &gt; 0)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; AddImageToImagePathContainer(CurrentThumbFileName);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; UpdateImagePathContainer();&nbsp; &nbsp; &nbsp; &nbsp; }}[/CODE]Should fix it up <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite8" alt=":D" title="Big Grin&nbsp; &nbsp; :D" loading="lazy" data-shortname=":D" />Also, is there any chance on getting [CODE]invalidSingleChars.Add('.');[/CODE]Removed from getValidURLLastFMString in AudioscrobblerUtils.cs for the reasons outlined in <a href="https://forum.team-mediaportal.com/showpost.php?p=83891&amp;postcount=174" target="_blank">this post</a>? <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite8" alt=":D" title="Big Grin&nbsp; &nbsp; :D" loading="lazy" data-shortname=":D" />Hope that all helps!!</blockquote>

[QUOTE="zombiepig, post: 85459, member: 12049"] Hey rtv - i think i've tracked down the problem with missing artist images. In GUIMusicPlayingNow.cs: function UpdateTrackInfo() has the lines: [CODE] if (CurrentTrackTag.Artist != PreviousTrackTag.Artist) UpdateArtistInfo(); [/CODE] So - if the artist is different to the last artist played, it runs UpdateArtistInfo, starts the ArtistInfoRequest thread, and then runs OnUpdateArtistInfoCompleted when the thread is complete. OnUpdateArtistInfoCompleted handles the actual adding of artist art to the viz window: [CODE] CurrentThumbFileName = Util.Utils.GetCoverArtName(Thumbs.MusicArtists, Util.Utils.FilterFileName(CurrentTrackTag.Artist)); if (CurrentThumbFileName.Length > 0) { AddImageToImagePathContainer(CurrentThumbFileName); UpdateImagePathContainer(); } [/CODE] Catch is, if the same artist is played twice in a row, UpdateArtistInfo will never be called and the artist thumbnail is not added to the container. The code in UpdateTrackInfo() should be something like: [CODE] if (CurrentTrackTag.Artist != PreviousTrackTag.Artist) UpdateArtistInfo(); else { CurrentThumbFileName = Util.Utils.GetCoverArtName(Thumbs.MusicArtists, Util.Utils.FilterFileName(CurrentTrackTag.Artist)); if (CurrentThumbFileName.Length > 0) { AddImageToImagePathContainer(CurrentThumbFileName); UpdateImagePathContainer(); } } [/CODE] Should fix it up :D Also, is there any chance on getting [CODE] invalidSingleChars.Add('.'); [/CODE] Removed from getValidURLLastFMString in AudioscrobblerUtils.cs for the reasons outlined in [URL="https://forum.team-mediaportal.com/showpost.php?p=83891&postcount=174"]this post[/URL]? :D Hope that all helps!! [/QUOTE]

Verification