Reply to thread

Message

<blockquote data-quote="zombiepig" data-source="post: 86229" data-attributes="member: 12049">Ok - tracked down whats causing my problem, and there's a little problem i've found in AudioscrobblerUtils.cs:like you said, getValidURLLastFMString is adding a + behind any .'s in the string. however, if the string already has a space after the .'s, getValidURLLastFMString incorrectly puts another space there (well, a + anyway <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite7" alt=":p" title="Stick Out Tongue&nbsp; &nbsp; :p" loading="lazy" data-shortname=":p" />). so, it's turning St. Anger into St.++Anger. This works ok for some strings, since last.fm seems to ignore it and return results anyway, but for other artists/cds, it just returns no results. Replacing the .++ with .+ returns the correct results. if i add a[CODE]&nbsp; &nbsp; &nbsp; &nbsp; outString = outString.Replace(&quot;++&quot;, &quot;+&quot;);[/CODE]after the [CODE]&nbsp; &nbsp; &nbsp; &nbsp; List&lt;Char&gt; invalidSingleChars = new List&lt;Char&gt;();&nbsp; &nbsp; &nbsp; &nbsp; invalidSingleChars.Add('.');&nbsp; &nbsp; &nbsp; &nbsp; invalidSingleChars.Add(',');&nbsp; &nbsp; &nbsp; &nbsp; foreach (Char singleChar in invalidSingleChars)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; do&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; dotIndex = urlString.IndexOf(singleChar);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (dotIndex &gt; 0)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (dotIndex &gt; lastIndex)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (dotIndex &lt; urlString.Length -1)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; lastIndex = dotIndex;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; outString = urlString.Insert(dotIndex + 1, &quot;+&quot;);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; urlString = outString;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; else&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; break;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; while (dotIndex &gt; 0);&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp;&nbsp; [/CODE]loop, then it fixes this problem. hope that helps!</blockquote>

[QUOTE="zombiepig, post: 86229, member: 12049"] Ok - tracked down whats causing my problem, and there's a little problem i've found in AudioscrobblerUtils.cs: like you said, getValidURLLastFMString is adding a + behind any .'s in the string. however, if the string already has a space after the .'s, getValidURLLastFMString incorrectly puts another space there (well, a + anyway :P). so, it's turning St. Anger into St.++Anger. This works ok for some strings, since last.fm seems to ignore it and return results anyway, but for other artists/cds, it just returns no results. Replacing the .++ with .+ returns the correct results. if i add a [CODE] outString = outString.Replace("++", "+"); [/CODE] after the [CODE] List<Char> invalidSingleChars = new List<Char>(); invalidSingleChars.Add('.'); invalidSingleChars.Add(','); foreach (Char singleChar in invalidSingleChars) { do { dotIndex = urlString.IndexOf(singleChar); if (dotIndex > 0) if (dotIndex > lastIndex) { if (dotIndex < urlString.Length -1) { lastIndex = dotIndex; outString = urlString.Insert(dotIndex + 1, "+"); urlString = outString; } } else break; } while (dotIndex > 0); } [/CODE] loop, then it fixes this problem. hope that helps! [/QUOTE]

Verification