Reply to thread

Message

<blockquote data-quote="dhasselqvist" data-source="post: 221695" data-attributes="member: 60604">Thank you for your answer. I have looked into the source code now and I think I'm able to fix this altough it will take some time since I haven't compiled anything for MP before. I also have another thought of how I want to change the behaviour of the plug-in if I'm changing the horizontal cropping. Right now when the autocropper is in DYNAMIC mode it is wrongfully cropping films that are being sent out with black bars because they are wider than 16:9. I think that the dynamic mode should only be engaged when 4:3 letterbox content is detected. I.e. when the AR is 4:3 the DYNAMIC mode works as it does right now but when the AR is detected to be less than 4:3 then the plug-in goes to OFF mode. So perhaps only two modes are needed ON and OFF (where ON actually goes between DYNAMIC and OFF depending on current AR and OFF disables the plug-in completely). What do you think about this? Also I think it would be good to disable the possibility to do manual cropping when the AR is less than 4:3 because if you by mistake hit the crop button on a wider movie you have no way off disregarding the latest crop.The reason I'm asking is because I want your input on the changes for the plug-in so that I'm not doing something that you don't approve off. Off course I can always make &quot;my own&quot; modified variant of your plug-in but I think it would be best to continue with this one so that everyone can benefit from my changes (if the are good enough of course <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile&nbsp; &nbsp; :)" loading="lazy" data-shortname=":)" /> ).</blockquote>

[QUOTE="dhasselqvist, post: 221695, member: 60604"] Thank you for your answer. I have looked into the source code now and I think I'm able to fix this altough it will take some time since I haven't compiled anything for MP before. I also have another thought of how I want to change the behaviour of the plug-in if I'm changing the horizontal cropping. Right now when the autocropper is in DYNAMIC mode it is wrongfully cropping films that are being sent out with black bars because they are wider than 16:9. I think that the dynamic mode should only be engaged when 4:3 letterbox content is detected. I.e. when the AR is 4:3 the DYNAMIC mode works as it does right now but when the AR is detected to be less than 4:3 then the plug-in goes to OFF mode. So perhaps only two modes are needed ON and OFF (where ON actually goes between DYNAMIC and OFF depending on current AR and OFF disables the plug-in completely). What do you think about this? Also I think it would be good to disable the possibility to do manual cropping when the AR is less than 4:3 because if you by mistake hit the crop button on a wider movie you have no way off disregarding the latest crop. The reason I'm asking is because I want your input on the changes for the plug-in so that I'm not doing something that you don't approve off. Off course I can always make "my own" modified variant of your plug-in but I think it would be best to continue with this one so that everyone can benefit from my changes (if the are good enough of course :) ). [/QUOTE]

Verification