Reply to thread

Message

<blockquote data-quote="andreavb" data-source="post: 203976" data-attributes="member: 28072">Well, I don't know if it's me that I'm watching an old piece of code (it should be a 0.2.3 RC2 version) but I've found a point in code [CODE]private void AvgDynamicCrop(int topCrop, int bottomCrop)[/CODE] that seems a little strange:I was watching the code cause I've seen a problem in cropping lower border when a little commercial or subtitle is shown on a faked 16:9 show in a 4:3 broadcast, when the little commercial or subtitle appears the crop suddenly expands to show the new part of the screen, then when the lower part of the screen is back to black it never shriks back and leaves this little piece of black in the bottom...following code I've found a strange piece of code:[CODE]&nbsp; &nbsp; &nbsp; if (topCropAvg.Average - lastSettings.Top &gt; 4 &amp;&amp; Math.Abs(topCropAvg.Average - topCrop) &lt; 2)&nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; newSettings.Top = (int)topCropAvg.Average;&nbsp; &nbsp; &nbsp; &nbsp; update = true;&nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; if (topCropAvg.Average - lastSettings.Top &gt; 4 &amp;&amp; Math.Abs(topCropAvg.Average - topCrop) &lt; 2)&nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; newSettings.Bottom = (int)bottomCropAvg.Average;&nbsp; &nbsp; &nbsp; &nbsp; update = true;&nbsp; &nbsp; &nbsp; }[/CODE]shouldn't the second if based on the bottomCropAvg instead of topCropAvg????it should be something like this in my opinion:[CODE]&nbsp; &nbsp; &nbsp; if (topCropAvg.Average - lastSettings.Top &gt; 4 &amp;&amp; Math.Abs(topCropAvg.Average - topCrop) &lt; 2)&nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; newSettings.Top = (int)topCropAvg.Average;&nbsp; &nbsp; &nbsp; &nbsp; update = true;&nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; if (bottomCropAvg.Average - lastSettings.Bottom &gt; 4 &amp;&amp; Math.Abs(bottomCropAvg.Average - bottomCrop) &lt; 2)&nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; newSettings.Bottom = (int)bottomCropAvg.Average;&nbsp; &nbsp; &nbsp; &nbsp; update = true;&nbsp; &nbsp; &nbsp; }[/CODE]plese let me know if it possible to fix this in next SVN...it seems that this is causing the issue I'm experiencing...in fact the bottom crop updates only when top crop changes tooplease coders let me know<img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite10" alt=":oops:" title="Oops!&nbsp; &nbsp; :oops:" loading="lazy" data-shortname=":oops:" /> <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite10" alt=":oops:" title="Oops!&nbsp; &nbsp; :oops:" loading="lazy" data-shortname=":oops:" /> <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite10" alt=":oops:" title="Oops!&nbsp; &nbsp; :oops:" loading="lazy" data-shortname=":oops:" /></blockquote>

[QUOTE="andreavb, post: 203976, member: 28072"] Well, I don't know if it's me that I'm watching an old piece of code (it should be a 0.2.3 RC2 version) but I've found a point in code [CODE]private void AvgDynamicCrop(int topCrop, int bottomCrop)[/CODE] that seems a little strange: I was watching the code cause I've seen a problem in cropping lower border when a little commercial or subtitle is shown on a faked 16:9 show in a 4:3 broadcast, when the little commercial or subtitle appears the crop suddenly expands to show the new part of the screen, then when the lower part of the screen is back to black it never shriks back and leaves this little piece of black in the bottom...following code I've found a strange piece of code: [CODE] if (topCropAvg.Average - lastSettings.Top > 4 && Math.Abs(topCropAvg.Average - topCrop) < 2) { newSettings.Top = (int)topCropAvg.Average; update = true; } if (topCropAvg.Average - lastSettings.Top > 4 && Math.Abs(topCropAvg.Average - topCrop) < 2) { newSettings.Bottom = (int)bottomCropAvg.Average; update = true; }[/CODE] shouldn't the second if based on the bottomCropAvg instead of topCropAvg???? it should be something like this in my opinion: [CODE] if (topCropAvg.Average - lastSettings.Top > 4 && Math.Abs(topCropAvg.Average - topCrop) < 2) { newSettings.Top = (int)topCropAvg.Average; update = true; } if (bottomCropAvg.Average - lastSettings.Bottom > 4 && Math.Abs(bottomCropAvg.Average - bottomCrop) < 2) { newSettings.Bottom = (int)bottomCropAvg.Average; update = true; }[/CODE] plese let me know if it possible to fix this in next SVN...it seems that this is causing the issue I'm experiencing...in fact the bottom crop updates only when top crop changes too please coders let me know :oops: :oops: :oops: [/QUOTE]

Verification