Reply to thread

Message

<blockquote data-quote="Sebastiii" data-source="post: 1208481" data-attributes="member: 60104">About this, i think movpic and Tvs / OV need to subscribe to MP event for updating properties, right now movpic and Tvs use a timer and does the refresh.Even plugins dev add a comment in code about the strange bug, so this timer should be enough in most case but it can happen that the delay is not enough for sure i can trigger it with madVR for ex.So i have add event on MP code (i need to look if i really add them in current master or not) and plugin dev need to adapt the code for it, like this when all is ok on MP side, the event is fired up and then movpic and Tvs can do proper filling <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite7" alt=":p" title="Stick Out Tongue&nbsp; &nbsp; :p" loading="lazy" data-shortname=":p" />The code for TVS :[CODE=WinBatch]diff --git a/MP-TVSeries/VideoHandler.cs b/MP-TVSeries/VideoHandler.csindex 763938f..5a144d7 100644--- a/MP-TVSeries/VideoHandler.cs+++ b/MP-TVSeries/VideoHandler.cs@@ -99,6 +99,7 @@ namespace WindowPlugins.GUITVSeries&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; g_Player.PlayBackEnded += new MediaPortal.Player.g_Player.EndedHandler(OnPlayBackEnded);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; g_Player.PlayBackStarted += new MediaPortal.Player.g_Player.StartedHandler(OnPlayBackStarted);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; g_Player.PlayBackChanged += new g_Player.ChangedHandler(OnPlaybackChanged);+&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; MediaPortal.GUI.Video.GUIVideoOverlay.SetGuiPropertiesUpdate += new MediaPortal.GUI.Video.GUIVideoOverlay.SetGuiProperties(SetGuiPropertiesUpdate);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; PlayPropertyUpdater.WorkerSupportsCancellation = true;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; PlayPropertyUpdater.DoWork += new DoWorkEventHandler(SetPlayProperties_DoWork);&nbsp; &nbsp; &nbsp; &nbsp;&nbsp; }@@ -304,6 +305,14 @@ namespace WindowPlugins.GUITVSeries&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; SetGUIProperties((bool)e.Argument);&nbsp; &nbsp; &nbsp; &nbsp;&nbsp; }+&nbsp; &nbsp; &nbsp; &nbsp; private void SetGuiPropertiesUpdate(g_Player.MediaType type, string filename)+&nbsp; &nbsp; &nbsp; &nbsp; {+&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (PlayBackOpIsOfConcern(type, filename))+&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {+&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; SetGUIProperties(false);+&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }+&nbsp; &nbsp; &nbsp; &nbsp; }+&nbsp; &nbsp; &nbsp; &nbsp;&nbsp; /// &lt;summary&gt;&nbsp; &nbsp; &nbsp; &nbsp;&nbsp; /// Sets the following Properties:&nbsp; &nbsp; &nbsp; &nbsp;&nbsp; /// &quot;#Play.Current.Title&quot;@@ -377,7 +386,7 @@ namespace WindowPlugins.GUITVSeries&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; GUIPropertyManager.SetProperty(kvp.Key, &quot; &quot;);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; }-&nbsp; &nbsp; &nbsp; &nbsp; +&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; GUIPropertyManager.SetProperty(&quot;#Play.Current.Title&quot;, clear ? &quot; &quot; : m_currentEpisode.onlineEpisode.CompleteTitle);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; GUIPropertyManager.SetProperty(&quot;#Play.Current.Year&quot;, clear ? &quot; &quot; : FieldGetter.resolveDynString(&quot;&lt;&quot; + DBEpisode.cOutName + &quot;.&quot; + DBOnlineEpisode.cFirstAired + &quot;&gt;&quot;, m_currentEpisode, false));&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; GUIPropertyManager.SetProperty(&quot;#Play.Current.Genre&quot;, clear ? &quot; &quot; : FieldGetter.resolveDynString(TVSeriesPlugin.m_sFormatEpisodeSubtitle, m_currentEpisode));@@ -587,6 +596,7 @@ namespace WindowPlugins.GUITVSeries&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; if (PlayBackOpIsOfConcern(type, filename))&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; LogPlayBackOp(&quot;started&quot;, filename);+&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; // TODO surely can be removed now.&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; // really stupid, you have to wait until the player itself sets the properties (a few seconds) and after that set them&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; PlayPropertyUpdater.RunWorkerAsync(false);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; }--2.10.0.windows.1[/CODE]So added this :MediaPortal.GUI.Video.GUIVideoOverlay.SetGuiPropertiesUpdate += new MediaPortal.GUI.Video.GUIVideoOverlay.SetGuiProperties(SetGuiPropertiesUpdate);andprivate void SetGuiPropertiesUpdate(g_Player.MediaType type, string filename)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (PlayBackOpIsOfConcern(type, filename))&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; SetGUIProperties(false);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; }[USER=52219]@ltfearme[/USER] what do you think ?Attached is the example for movpic <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite7" alt=":p" title="Stick Out Tongue&nbsp; &nbsp; :p" loading="lazy" data-shortname=":p" /></blockquote>

[QUOTE="Sebastiii, post: 1208481, member: 60104"] About this, i think movpic and Tvs / OV need to subscribe to MP event for updating properties, right now movpic and Tvs use a timer and does the refresh. Even plugins dev add a comment in code about the strange bug, so this timer should be enough in most case but it can happen that the delay is not enough for sure i can trigger it with madVR for ex. So i have add event on MP code (i need to look if i really add them in current master or not) and plugin dev need to adapt the code for it, like this when all is ok on MP side, the event is fired up and then movpic and Tvs can do proper filling :p The code for TVS : [CODE=WinBatch]diff --git a/MP-TVSeries/VideoHandler.cs b/MP-TVSeries/VideoHandler.cs index 763938f..5a144d7 100644 --- a/MP-TVSeries/VideoHandler.cs +++ b/MP-TVSeries/VideoHandler.cs @@ -99,6 +99,7 @@ namespace WindowPlugins.GUITVSeries g_Player.PlayBackEnded += new MediaPortal.Player.g_Player.EndedHandler(OnPlayBackEnded); g_Player.PlayBackStarted += new MediaPortal.Player.g_Player.StartedHandler(OnPlayBackStarted); g_Player.PlayBackChanged += new g_Player.ChangedHandler(OnPlaybackChanged); + MediaPortal.GUI.Video.GUIVideoOverlay.SetGuiPropertiesUpdate += new MediaPortal.GUI.Video.GUIVideoOverlay.SetGuiProperties(SetGuiPropertiesUpdate); PlayPropertyUpdater.WorkerSupportsCancellation = true; PlayPropertyUpdater.DoWork += new DoWorkEventHandler(SetPlayProperties_DoWork); } @@ -304,6 +305,14 @@ namespace WindowPlugins.GUITVSeries SetGUIProperties((bool)e.Argument); } + private void SetGuiPropertiesUpdate(g_Player.MediaType type, string filename) + { + if (PlayBackOpIsOfConcern(type, filename)) + { + SetGUIProperties(false); + } + } + /// <summary> /// Sets the following Properties: /// "#Play.Current.Title" @@ -377,7 +386,7 @@ namespace WindowPlugins.GUITVSeries GUIPropertyManager.SetProperty(kvp.Key, " "); } } - + GUIPropertyManager.SetProperty("#Play.Current.Title", clear ? " " : m_currentEpisode.onlineEpisode.CompleteTitle); GUIPropertyManager.SetProperty("#Play.Current.Year", clear ? " " : FieldGetter.resolveDynString("<" + DBEpisode.cOutName + "." + DBOnlineEpisode.cFirstAired + ">", m_currentEpisode, false)); GUIPropertyManager.SetProperty("#Play.Current.Genre", clear ? " " : FieldGetter.resolveDynString(TVSeriesPlugin.m_sFormatEpisodeSubtitle, m_currentEpisode)); @@ -587,6 +596,7 @@ namespace WindowPlugins.GUITVSeries if (PlayBackOpIsOfConcern(type, filename)) { LogPlayBackOp("started", filename); + // TODO surely can be removed now. // really stupid, you have to wait until the player itself sets the properties (a few seconds) and after that set them PlayPropertyUpdater.RunWorkerAsync(false); } -- 2.10.0.windows.1 [/CODE] So added this : MediaPortal.GUI.Video.GUIVideoOverlay.SetGuiPropertiesUpdate += new MediaPortal.GUI.Video.GUIVideoOverlay.SetGuiProperties(SetGuiPropertiesUpdate); and private void SetGuiPropertiesUpdate(g_Player.MediaType type, string filename) { if (PlayBackOpIsOfConcern(type, filename)) { SetGUIProperties(false); } } [USER=52219]@ltfearme[/USER] what do you think ? Attached is the example for movpic :P [/QUOTE]

Verification