Reply to thread

Message

<blockquote data-quote="sunsetdk" data-source="post: 145439" data-attributes="member: 15617">SourceI have added the method GetCommertials. This is suppose to be run when a film is started but i couldn't find that place in the source. This sub checks if there is a comskip file and if it is valid, if it is it will load all commertials from the file and saved in a array. I have added some code that check if getcommertials is executed with the same movie twice, this can be removed if the sub is only called once when a new movie starts. When the user press up or down i want to check if a comskip file was found. Again as i couldn't find the right place to put the getcommertials this is done a bit different, as i run this method each time the user press up or down.But if commertials is found and the movie is in a block of commertials when the up button is pressed i skip to the end of the commertial block. If the used press back up to 10 sec after a commertial block i skip to the start of the commertials block.Your implimentation looks good, but i see one problem with it as it always skips to the end of the next commertials block.If comskip only found comertial block 1 and 3 in a show with 3 blocks, when you are on block 2 and press skip, you will end up at the end of block 3 which wasn't the point.Don't take this a criticisms <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile&nbsp; &nbsp; :)" loading="lazy" data-shortname=":)" />Ask if the source doesn't make sence.</blockquote>

[QUOTE="sunsetdk, post: 145439, member: 15617"] [b]Source[/b] I have added the method GetCommertials. This is suppose to be run when a film is started but i couldn't find that place in the source. This sub checks if there is a comskip file and if it is valid, if it is it will load all commertials from the file and saved in a array. I have added some code that check if getcommertials is executed with the same movie twice, this can be removed if the sub is only called once when a new movie starts. When the user press up or down i want to check if a comskip file was found. Again as i couldn't find the right place to put the getcommertials this is done a bit different, as i run this method each time the user press up or down. But if commertials is found and the movie is in a block of commertials when the up button is pressed i skip to the end of the commertial block. If the used press back up to 10 sec after a commertial block i skip to the start of the commertials block. Your implimentation looks good, but i see one problem with it as it always skips to the end of the next commertials block. If comskip only found comertial block 1 and 3 in a show with 3 blocks, when you are on block 2 and press skip, you will end up at the end of block 3 which wasn't the point. Don't take this a criticisms :) Ask if the source doesn't make sence. [/QUOTE]

Verification