Reply to thread

Message

<blockquote data-quote="doskabouter" data-source="post: 1286854" data-attributes="member: 98267">Just did a quick scan of your code changes...That is quite a lot of work you put into that and hard to understand all its changes, but I'll give it a deeper looking into soon.Don't know if this is still feasible but do you think when you're making your final pull-request, you could split up your commits into these kinds:<ul>
<li data-xf-list-type="ul">refactoring code</li>
<li data-xf-list-type="ul">renaming variables/methods</li>
<li data-xf-list-type="ul">improve/add/remove logging</li>
<li data-xf-list-type="ul">fixing typos</li>
<li data-xf-list-type="ul">unifying whitespace</li>
<li data-xf-list-type="ul">actual relevant code/functionality changes</li>
</ul>Preferably with clear commit-messages? (And preferably without too much noise like moving down &quot;using MediaPortal.Database;&quot; a couple of lines)Ofcourse this is isn't a list set in stone, more of a general idea...That will make it much easier to grasp the gist of your changes and for people in the future to trace back what actually happened.Some other tips: <ul>
<li data-xf-list-type="ul">please avoid empty catch blocks, at the very least log a warning in it.</li>
<li data-xf-list-type="ul">Did you think of the usecase where a new video is added to your video folder somewhere and that multiple clients are going to fetch all the details/thumbs/etc of that video? Or was that covered by assuming no 2 clients are going to go to that updated folder in the same time?</li>
</ul>I don't really use the databases that had changed by you (Only ones I use are movingpictures, onlinevideos, picturedatabase very rare, and videodatabase only for keeping track of which episodes of series I have watched),&nbsp; so I can't give you much insight/help with determining and testing functionality unfortunately</blockquote>

[QUOTE="doskabouter, post: 1286854, member: 98267"] Just did a quick scan of your code changes... That is quite a lot of work you put into that and hard to understand all its changes, but I'll give it a deeper looking into soon. Don't know if this is still feasible but do you think when you're making your final pull-request, you could split up your commits into these kinds: [LIST] [*]refactoring code [*]renaming variables/methods [*]improve/add/remove logging [*]fixing typos [*]unifying whitespace [*]actual relevant code/functionality changes [/LIST] Preferably with clear commit-messages? (And preferably without too much noise like moving down "using MediaPortal.Database;" a couple of lines) Ofcourse this is isn't a list set in stone, more of a general idea... That will make it much easier to grasp the gist of your changes and for people in the future to trace back what actually happened. Some other tips: [LIST] [*]please avoid empty catch blocks, at the very least log a warning in it. [*]Did you think of the usecase where a new video is added to your video folder somewhere and that multiple clients are going to fetch all the details/thumbs/etc of that video? Or was that covered by assuming no 2 clients are going to go to that updated folder in the same time? [/LIST] I don't really use the databases that had changed by you (Only ones I use are movingpictures, onlinevideos, picturedatabase very rare, and videodatabase only for keeping track of which episodes of series I have watched), so I can't give you much insight/help with determining and testing functionality unfortunately [/QUOTE]

Verification