Reply to thread

Message

<blockquote data-quote="Maschine" data-source="post: 242763" data-attributes="member: 10316">Hey Midget,I looked at your patch today. I'm sorry, but I won't integrate it to our SVN. The patch itself is fine, all your changes look good, but more changes need to be done, especially within the configuration app.1) Deleting recordings is a very critical topic. Many users don't want MP to delete anything. They'll prefer loosing the new recording (which can't start because of no disk space) over getting their old files deleted. So we need a general option to turn diskmanagement completely off.2) The check for free disk space is currently done for all drives on the computer. Imagine a scenario with 1 system disk and 1 disk for recordings. The system disk has just 200 MB free space while the recordings disk still has 50+GB free space. Diskmanagement will start to delete one recording after another because the system disk won't get any more space. ==&gt; Diskmanagement should only monitor those drives that actually contain recordings (i.e. the recordings folder is on those disks).If you add those 2 points, I can add your patch to the official builds. In its current state I need to reject it, sorry.I hope you understand my descission and &quot;fix&quot; the 2 mentioned issues, because -as I said above- your code itself is fine.Maschine</blockquote>

[QUOTE="Maschine, post: 242763, member: 10316"] Hey Midget, I looked at your patch today. I'm sorry, but I won't integrate it to our SVN. The patch itself is fine, all your changes look good, but more changes need to be done, especially within the configuration app. 1) Deleting recordings is a very critical topic. Many users don't want MP to delete anything. They'll prefer loosing the new recording (which can't start because of no disk space) over getting their old files deleted. So we need a general option to turn diskmanagement completely off. 2) The check for free disk space is currently done for all drives on the computer. Imagine a scenario with 1 system disk and 1 disk for recordings. The system disk has just 200 MB free space while the recordings disk still has 50+GB free space. Diskmanagement will start to delete one recording after another because the system disk won't get any more space. ==> Diskmanagement should only monitor those drives that actually contain recordings (i.e. the recordings folder is on those disks). If you add those 2 points, I can add your patch to the official builds. In its current state I need to reject it, sorry. I hope you understand my descission and "fix" the 2 mentioned issues, because -as I said above- your code itself is fine. Maschine [/QUOTE]

Verification