[Pending] - DVB EPG Grab delay in seconds

Discussion in 'Submit: code patches (MediaPortal/TV-Server/etc.)' started by Vasilich, July 1, 2011.

  1. Vasilich
    • Team MediaPortal

    Vasilich Test Group

    Joined:
    August 30, 2009
    Messages:
    3,392
    Likes Received:
    608
    Gender:
    Male
    Occupation:
    Developer
    Location:
    Germany, Mayence
    Ratings:
    +1,173 / 2
    Home Country:
    Russian Federation Russian Federation
    Show System Specs
    right now DVB EPG grab time can be set only in minutes, and i found no reason why we have to wait at least one minute for EPG grabbing - other programs don't have such long delay before grabbing starts. So first part of patch changes delay units for this from minutes to seconds.
    Another part of patch sets minimum value for delay to 1 instead of 0 - i tried to set it to 0 somewhen and wasn't able to watch TV with exception loggged.


     

    Attached Files:

    Last edited by a moderator: March 15, 2013
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. tourettes
    • Premium Supporter

    tourettes Retired Team Member

    Joined:
    January 7, 2005
    Messages:
    17,301
    Likes Received:
    4,595
    Ratings:
    +4,810 / 3
    In that case shouldn't we make sanitise the user input to be > 0? :)
     
  4. Vasilich
    • Team MediaPortal

    Vasilich Test Group

    Joined:
    August 30, 2009
    Messages:
    3,392
    Likes Received:
    608
    Gender:
    Male
    Occupation:
    Developer
    Location:
    Germany, Mayence
    Ratings:
    +1,173 / 2
    Home Country:
    Russian Federation Russian Federation
    Show System Specs
    tourettes, it is done in this patch - UpDown control takes care of it.
     
  5. arion_p
    • Premium Supporter

    arion_p Retired Team Member

    Joined:
    February 7, 2007
    Messages:
    3,352
    Likes Received:
    1,447
    Occupation:
    Developer
    Location:
    Athens
    Ratings:
    +1,522 / 0
    Home Country:
    Greece Greece
    Show System Specs
    So what happens with upgrades?
    If pre-upgrade configured value was 5 min will it still be treated as 5 min after upgrade or will it be interpreted as 5 seconds?
    By looking at the code it seems to me it will be the latter.
     
  6. Vasilich
    • Team MediaPortal

    Vasilich Test Group

    Joined:
    August 30, 2009
    Messages:
    3,392
    Likes Received:
    608
    Gender:
    Male
    Occupation:
    Developer
    Location:
    Germany, Mayence
    Ratings:
    +1,173 / 2
    Home Country:
    Russian Federation Russian Federation
    Show System Specs
    yes, there is nothing about upgrade in the patch, so default 5 minutes switch to 5 seconds. Do you believe there is any reason to wait soo long?
    Not sure what was the idea to make this delay to be set in minutes - there is enough threads with "why DVBViewer/MyTheater/DVBPortal get DVB EPG almost instantly and in MP we have to wait some minutes?"
     
    Last edited: May 16, 2012
  7. arion_p
    • Premium Supporter

    arion_p Retired Team Member

    Joined:
    February 7, 2007
    Messages:
    3,352
    Likes Received:
    1,447
    Occupation:
    Developer
    Location:
    Athens
    Ratings:
    +1,522 / 0
    Home Country:
    Greece Greece
    Show System Specs
    Not sure why it was set in minutes. But what I'm after is that if a user has configured 5 minutes (or even 1 minute) he has done it for a reason (perhaps it uses too many resources). On upgrade this will be changed to 5 seconds (or 1 second) behind his back which is not what the user configured. We have to respect the user configured values and any upgrade should not change them arbitrarily unless there is a very good reason for doing so.

    In the above case what would happen if user configure 1minute and we essentially change that to 1 second? Is 1 second enough to grab EPG for say 2000 channels on DVBS? As far as I can tell from TsWriter code, EPG grabber sends data back to TVServer after there has been no epg data packets fro 1 minute, so setting a timeout < 1minute will essentially always abort the grab.
     
  8. Vasilich
    • Team MediaPortal

    Vasilich Test Group

    Joined:
    August 30, 2009
    Messages:
    3,392
    Likes Received:
    608
    Gender:
    Male
    Occupation:
    Developer
    Location:
    Germany, Mayence
    Ratings:
    +1,173 / 2
    Home Country:
    Russian Federation Russian Federation
    Show System Specs
    i tested this patch last year, and it worked, i.e. grabbed EPG in 2-3 seconds.
    about upgrade - should i build logic in installer to multiply existing values to 60?
     
  9. schwarzrz

    schwarzrz Portal Pro

    Joined:
    May 23, 2010
    Messages:
    370
    Likes Received:
    28
    Gender:
    Male
    Location:
    Frankfurt
    Ratings:
    +57 / 1
    Home Country:
    Germany Germany
    Show System Specs
    Hi Vasilich,
    how do I use your patch? = what to do or were to copy?
    Thanks in advance
     
  10. Vasilich
    • Team MediaPortal

    Vasilich Test Group

    Joined:
    August 30, 2009
    Messages:
    3,392
    Likes Received:
    608
    Gender:
    Male
    Occupation:
    Developer
    Location:
    Germany, Mayence
    Ratings:
    +1,173 / 2
    Home Country:
    Russian Federation Russian Federation
    Show System Specs
    apply to GIT source code and compile TV part
     
  11. snowball

    snowball Portal Pro

    Joined:
    December 24, 2008
    Messages:
    51
    Likes Received:
    12
    Ratings:
    +12 / 0
    Home Country:
    Germany Germany
    Hi Vasilich, Arion_p,

    although this thread is older and it doesnt seem that it gets implemented into MP as it is proposed.

    i had the same issue, and i solved it differently i didnt switched to seconds, but allowed floating values so 1 minute will be still one minute but setting to 0,5 will be half a minute. the codechange is also not very intrusive.
    @arion_p
    do you think that is an acceptable change?
    then i will start a new thread and provide the patch there

    Cheers Snow
     
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!