Reply to thread

Message

<blockquote data-quote="XMaM" data-source="post: 1175489" data-attributes="member: 134551">[USER=68833]@ajs[/USER]I found something strange for me in the source code:File: Utils.cs, lines 1681, 1682, function LoadSettings()[code=csharp]UseMyPicturesSlideShow = settings.GetValueAsBool(&quot;FanartHandler&quot;, &quot;UseMyPicturesSlideShow&quot;, UseMyPicturesSlideShow);UseMyPicturesSlideShow = settings.GetValueAsBool(&quot;FanartHandler&quot;, &quot;FastScanMyPicturesSlideShow&quot;, FastScanMyPicturesSlideShow);[/code]In the second line, UseMyPicturesSlideShow is loaded again with the value obtained from FastScanMyPicturesSlideShow. As far as I can see, this isn't used in FanartHandler.xml, so is loaded with the default value: false.In fact, in function SaveSettings(), lines 1797-1798, the &quot;parallel&quot; line is comented, so from here, FastScanMyPicturesSlideShow is never stored:[code=csharp]xmlwriter.SetValueAsBool(&quot;FanartHandler&quot;, &quot;UseMyPicturesSlideShow&quot;, UseMyPicturesSlideShow);// xmlwriter.SetValueAsBool(&quot;FanartHandler&quot;, &quot;FastScanMyPicturesSlideShow&quot;, FastScanMyPicturesSlideShow);[/code]Also in LoadMyPicturesSlideShowFolders() (line 1451), the first check don't load the folders if UseMyPicturesSlideShow is false[code=csharp]&nbsp; &nbsp; public static void LoadMyPicturesSlideShowFolders()&nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; if (!UseMyPicturesSlideShow)&nbsp; &nbsp; &nbsp; &nbsp; return; &nbsp; &nbsp; &nbsp; try&nbsp; &nbsp; &nbsp; {[/code]In this case, probably will be better load folder settings regardless of the value in UseMyPicturesSlideShow. Maybe someone wants deactivate temporarily UseMyPicturesSlideShow but retaining his folder configuración. The same when saving.I hope this can help. Thanks.</blockquote>

[QUOTE="XMaM, post: 1175489, member: 134551"] [USER=68833]@ajs[/USER] I found something strange for me in the source code: File: Utils.cs, lines 1681, 1682, function LoadSettings() [code=csharp]UseMyPicturesSlideShow = settings.GetValueAsBool("FanartHandler", "UseMyPicturesSlideShow", UseMyPicturesSlideShow); UseMyPicturesSlideShow = settings.GetValueAsBool("FanartHandler", "FastScanMyPicturesSlideShow", FastScanMyPicturesSlideShow);[/code] In the second line, UseMyPicturesSlideShow is loaded again with the value obtained from FastScanMyPicturesSlideShow. As far as I can see, this isn't used in FanartHandler.xml, so is loaded with the default value: false. In fact, in function SaveSettings(), lines 1797-1798, the "parallel" line is comented, so from here, FastScanMyPicturesSlideShow is never stored: [code=csharp]xmlwriter.SetValueAsBool("FanartHandler", "UseMyPicturesSlideShow", UseMyPicturesSlideShow); // xmlwriter.SetValueAsBool("FanartHandler", "FastScanMyPicturesSlideShow", FastScanMyPicturesSlideShow);[/code] Also in LoadMyPicturesSlideShowFolders() (line 1451), the first check don't load the folders if UseMyPicturesSlideShow is false [code=csharp] public static void LoadMyPicturesSlideShowFolders() { if (!UseMyPicturesSlideShow) return; try {[/code] In this case, probably will be better load folder settings regardless of the value in UseMyPicturesSlideShow. Maybe someone wants deactivate temporarily UseMyPicturesSlideShow but retaining his folder configuración. The same when saving. I hope this can help. Thanks. [/QUOTE]

Verification