Reply to thread

Message

<blockquote data-quote="gemx" data-source="post: 250492" data-attributes="member: 26324">Hmm, at first i don't understand this line[CODE]&nbsp; &nbsp; &nbsp; &nbsp; public bool showDialogOnThreshold(ArrayList hits)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (GUIWindowManager.ActiveWindow != GetID)[/CODE]The dialog is only shown if another window than this plugin is shown.I would assume that the dialog shows up even if i am already in the plugin screen because i may have forgotten about the exact threshold values.Regarding the actual bug, i am not quite sure but it's this is not a good idea:[CODE]&nbsp; &nbsp; &nbsp; &nbsp; protected override void OnPageDestroy(int newWindowId)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (timer != null &amp;&amp; timer.Enabled)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; timer.Stop();&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Info(&quot;PAGEDESTROY&quot;);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (wantsAlarm)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; startAlarmTimer();&nbsp; &nbsp; &nbsp; &nbsp; }[/CODE]You start the timer when the page gets destroyed.This might cause issues too.</blockquote>

[QUOTE="gemx, post: 250492, member: 26324"] Hmm, at first i don't understand this line [CODE] public bool showDialogOnThreshold(ArrayList hits) { if (GUIWindowManager.ActiveWindow != GetID) [/CODE] The dialog is only shown if another window than this plugin is shown. I would assume that the dialog shows up even if i am already in the plugin screen because i may have forgotten about the exact threshold values. Regarding the actual bug, i am not quite sure but it's this is not a good idea: [CODE] protected override void OnPageDestroy(int newWindowId) { if (timer != null && timer.Enabled) { timer.Stop(); } Info("PAGEDESTROY"); if (wantsAlarm) startAlarmTimer(); } [/CODE] You start the timer when the page gets destroyed. This might cause issues too. [/QUOTE]

Verification