- Moderator
- #1
Problem:
thumbZoom is not enabled for filmstrip. This gives a skinner only two ways to display mixed landscape and portrait pictures:
Option 1, keepaspectratio=no
Advantage=aspectratio is kept, disadvantage=image is zoomed and not shown entirely
Option 2, keepaspectratio=yes
Advantage=whole image is shown, disadvantage=aspectratio disturbed
New option, thumbZoom
Advantage=image is not zoomed and aspectratio is kept, disadvantage=does not fill the frame
When I enabled keepaspectratio for Coverflow I was asked to add support for thumbZoom as well, as this is way more useful.
I also added two new properties to align the thumb vertically and horizontally.
Now I have done the same for filmstrip:
3 new properties have been added:
If this a feature that may be added for 1.2.0 RC or later, then that is fine with me. I just wanted to complete the circle, since we now have thumbZoom for thumbs and coverflow already...
Patch against SVN 27537 attached.
thumbZoom is not enabled for filmstrip. This gives a skinner only two ways to display mixed landscape and portrait pictures:
Option 1, keepaspectratio=no
Advantage=aspectratio is kept, disadvantage=image is zoomed and not shown entirely
Option 2, keepaspectratio=yes
Advantage=whole image is shown, disadvantage=aspectratio disturbed
New option, thumbZoom
Advantage=image is not zoomed and aspectratio is kept, disadvantage=does not fill the frame
When I enabled keepaspectratio for Coverflow I was asked to add support for thumbZoom as well, as this is way more useful.
I also added two new properties to align the thumb vertically and horizontally.
Now I have done the same for filmstrip:
3 new properties have been added:
Code:
[XMLSkinElement("thumbZoom")] protected bool _zoom = false;
[XMLSkinElement("thumbAlign")] protected Alignment _imageAlignment = Alignment.ALIGN_CENTER;
[XMLSkinElement("thumbVAlign")] protected VAlignment _imageVAlignment = VAlignment.ALIGN_BOTTOM;
If this a feature that may be added for 1.2.0 RC or later, then that is fine with me. I just wanted to complete the circle, since we now have thumbZoom for thumbs and coverflow already...
Patch against SVN 27537 attached.