[Rejected] fix/workaround 0002914: When using RTSP, audio/video format change may cause video... (1 Viewer)

disaster123

MP Donator
  • Premium Supporter
  • May 14, 2008
    3,558
    434
    Home Country
    Germany Germany
    Hi,

    as some devs have already mentioned in https://forum.team-mediaportal.com/...rc2-switching-hd-channels-fails-random-80840/ we propably won't see any real fix for that mantis entry.

    But this is still a very annoying bug. So i want to provide a workaround.

    You'll find it attached.

    EDIT:
    Added a V2 version of the patch.
    Changes:
    - checks only for whole seconds (1s resolution) - this prevents from looping 2-3 times like the 1st patch does
    - added explanation to code
    - reformatted to meet the MP requirements of 2 spaces instead of 4


    Stefan
     

    Attachments

    • fix_rtsp_audio_loop.patch
      1.2 KB
    • fix_rtsp_audio_loopV2.patch
      1.6 KB

    disaster123

    MP Donator
  • Premium Supporter
  • May 14, 2008
    3,558
    434
    Home Country
    Germany Germany
    AW: fix/workaround 0002914: When using RTSP, audio/video format change may cause vide

    an additional note - i use this piece of code since a few days and it is working nicely. When the issue happens your channel change is still longer than a normal channel change as the audiochange triggering is still happing about 2-3 times instead only once but MP doesn't freeze in an endless loop - which makes rtsp useable again.
     

    regeszter

    Retired Team Member
  • Premium Supporter
  • October 29, 2005
    5,335
    4,954
    Home Country
    Hungary Hungary
    Re: fix/workaround 0002914: When using RTSP, audio/video format change may cause vide

    I suffer for this issue. Pls complie a version for 1.1.2 any I will test for you.
     

    disaster123

    MP Donator
  • Premium Supporter
  • May 14, 2008
    3,558
    434
    Home Country
    Germany Germany
    AW: fix/workaround 0002914: When using RTSP, audio/video format change may cause vide

    sorry i've no 1.1.2 anymore running i can compile a version for the actual SVN...
     

    disaster123

    MP Donator
  • Premium Supporter
  • May 14, 2008
    3,558
    434
    Home Country
    Germany Germany
    AW: fix/workaround 0002914: When using RTSP, audio/video format change may cause vide

    new version of patch attached
     

    disaster123

    MP Donator
  • Premium Supporter
  • May 14, 2008
    3,558
    434
    Home Country
    Germany Germany
    AW: fix/workaround 0002914: When using RTSP, audio/video format change may cause vide

    has anybody else than me tested this one? I really would like to have some feeback.
     

    tourettes

    Retired Team Member
  • Premium Supporter
  • January 7, 2005
    17,301
    4,800
    Re: AW: fix/workaround 0002914: When using RTSP, audio/video format change may cause

    has anybody else than me tested this one? I really would like to have some feeback.

    I checked the patch, it could be used as last resort since it is not curing the real issue but hiding it and most likely if user manages to seek twice in "good spot" then it could cause audio stream changing to fail when it would be required.

    We are currently testing a TsReader side fix internally - it cures the same issue in single seat (it happens mch more rarely on the single seat). Let's see how that goes for RTSP, cannot promise anything yet.
     

    disaster123

    MP Donator
  • Premium Supporter
  • May 14, 2008
    3,558
    434
    Home Country
    Germany Germany
    AW: fix/workaround 0002914: When using RTSP, audio/video format change may cause vide

    > if user manages to seek twice in "good spot"
    what do you mean by that? I cannot imagine such a situation. What about doing a public testing regarding this issue?
     

    tourettes

    Retired Team Member
  • Premium Supporter
  • January 7, 2005
    17,301
    4,800
    Re: AW: fix/workaround 0002914: When using RTSP, audio/video format change may cause

    > if user manages to seek twice in "good spot"
    what do you mean by that? I cannot imagine such a situation.

    Skipping up / down over a audio boundary could ignore the last audio type change - that could freeze the video if no audio stream that matches "the one before the final skip" is not available.

    What about doing a public testing regarding this issue?

    No one has tested it internally yet (and I have no access to mutliseat).
     

    tourettes

    Retired Team Member
  • Premium Supporter
  • January 7, 2005
    17,301
    4,800
    Re: fix/workaround 0002914: When using RTSP, audio/video format change may cause vide

    Here's the TsReader side patch. This fixes the similar issue for singleseat, but as I couldn't get anyone inside the team to check the mutiseat please test. It is highly likely that it wont fix the RTSP related issue (those are most likely having different root causes) but at least it is worth to try since it fixes a real issue in any case (seeking position could be less than asked and that could lead into a infinite loop of PAT / PMT changes).
     

    Attachments

    • TsReader_v3.zip
      174.8 KB
    • seeking_fix.patch
      1.2 KB

    Users who are viewing this thread

    Top Bottom