[Approved] Fixed Imagelist not scaled to window-size (1 Viewer)

[pilehave]

Problem:

An imagelist was properly resized on the X/Y placement, but the subitems were not. See screenshots:


Default window-size; 720x576


1920x1080 (skin design size)

Observe how the stars under the poster are excactly same size (compare images in 100% zoom), even though other elements are scaled to size.

Solution:

Resize width and height of the texture (stars) before creating the images

      GUIGraphicsContext.ScaleHorizontal(ref _textureWidth);
      GUIGraphicsContext.ScaleVertical(ref _textureHeight);

Patch against SVN 27318 attached.

Screenshot below shows the fix applied.


Default window-size; 720x576

 

[SilentException]

Nice, thanks. Haven't looked at the patch yet but this is one of those old bugs that has been bugging me before but forgot about it

 

[pilehave]

Can this perhaps make it into 1.2.0? Really simple patch

 

[SilentException]

r27470. Thanks for the fix!

 

[Dadeo]

First, thank you both so much for this fix. It has been bugging me for ages as well! I even reported the bug twice in the past! So three cheers to you both for finally getting this in MP!

Correct me if I am wrong, but I think this fix does require skin changes in many cases and should be documented so skinners know (the Mantis issue is marked as Docs Required = No) In the past, skins often resized imagelists to adjust for this bug.

For example, see the two screenshots below of the rating stars in Video Titles in Blue3wide. This is the exact same xml control/code in myvideotitles.xml in 1.1.2 and 1.2.0 (after the fix). So I suspect at least some skins, included our default skins, will require changes.