Reply to thread

Message

<blockquote data-quote="Lightning303" data-source="post: 1125538" data-attributes="member: 97876">Just to be clear from the start, AtmoLight is the only plugin that uses this feature atm, but that does not mean this is a AtmoLight specific feature. So when we talk about this, we should not just think about that one specfic area where the FrameGrabber can be used.Before this patch the FrameGrabber event was only raised by the video player renderer. In this patch i added in that the event gets also raised by the gui rendering. Something interesting here is, that while a video is playing, the &quot;normal&quot; gui rendering methods are not used, even when the video is not in fullscreen. Without having looked any deeper into the code now, my guess is the videoplayer is rendering the gui in this instance aswell. Somehow, somewhere.Talking about ambilight, i agree that it would be better/consistent that when a video is not in fullscreen, the video frame should not be used, but the whole screen frame. However changing that would also possibly interfere with other plugins that use the framegrabber and rely on how it is acting while video playback. E.g. i know that the the ViewModeSwitcher plugin uses the framegrabber.Lastly, i dont think i will be doing anything on this anymore. I just dont feel like it. Sorry. Still, thanks for testing and giving feedback <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile&nbsp; &nbsp; :)" loading="lazy" data-shortname=":)" />.</blockquote>

[QUOTE="Lightning303, post: 1125538, member: 97876"] Just to be clear from the start, AtmoLight is the only plugin that uses this feature atm, but that does not mean this is a AtmoLight specific feature. So when we talk about this, we should not just think about that one specfic area where the FrameGrabber can be used. Before this patch the FrameGrabber event was only raised by the video player renderer. In this patch i added in that the event gets also raised by the gui rendering. Something interesting here is, that while a video is playing, the "normal" gui rendering methods are not used, even when the video is not in fullscreen. Without having looked any deeper into the code now, my guess is the videoplayer is rendering the gui in this instance aswell. Somehow, somewhere. Talking about ambilight, i agree that it would be better/consistent that when a video is not in fullscreen, the video frame should not be used, but the whole screen frame. However changing that would also possibly interfere with other plugins that use the framegrabber and rely on how it is acting while video playback. E.g. i know that the the ViewModeSwitcher plugin uses the framegrabber. Lastly, i dont think i will be doing anything on this anymore. I just dont feel like it. Sorry. Still, thanks for testing and giving feedback :). [/QUOTE]

Verification