home
products
contribute
download
documentation
forum
Home
Forums
New posts
Search forums
What's new
New posts
All posts
Latest activity
Members
Registered members
Current visitors
Donate
Log in
Register
What's new
Search
Search
Search titles only
By:
New posts
Search forums
Search titles only
By:
Menu
Log in
Register
Navigation
Install the app
Install
More options
Contact us
Close Menu
Forums
MediaPortal 1
Development
Submit: code patches (MediaPortal/TV-Server/etc.)
Framegrabber improvement - Capture from UI when Video is minimized or running in Mini-display
Contact us
RSS
JavaScript is disabled. For a better experience, please enable JavaScript in your browser before proceeding.
You are using an out of date browser. It may not display this or other websites correctly.
You should upgrade or use an
alternative browser
.
Reply to thread
Message
<blockquote data-quote="Lightning303" data-source="post: 1127890" data-attributes="member: 97876"><p>In regards to AtmoLight, i dont think this is the right solution. I just flew over the patches, so maybe im missing something or misunderstanding. But from what i can see, you mainly renamed the event.</p><p>In AtmoLight you added a new setting, to choose if one wants to use the new event. If this setting is enabled AtmoLight subscribes to the new event, if not, it tries to subscribe to the old one. But this only adds support for pre change and post change versions. Nothing else is added by this.</p><p>If i enable the settings gui capture works, and if i watch a video and then minimize it, AtmoLight reveives the GUI data.</p><p>If i disable this settings, MediaPortal Live Mode will only work during video playback, Live Mode in GUI (no media playback) is not working at all anymore.</p><p></p><p>So instead of toggling which source should be used when we minimize a video (which was the idea of all of this), we now can toggle between "Show exactly what is on screen" and "Dont ever show GUI frames (AtmoLight behaviour from before 1.11pre).</p><p></p><p>So why would i want to ever disable this with MP1.12 or ever enable this with older versions? It just adds confusion.</p><p></p><p>Maybe the best approch is to let MediaPortal raise the OnNewFrame event on every new frame. So if we minimize a video, let an event get raised for every GUI frame and an event for every video frame. And then attach an identifier of where this frame came from (gui or video renderer). Then let ViewModeSwicther and AtmoLight decide which frame to use and which to discard. Yes, this means if you want to use a new MP version you would need to update AtmoLight to a new version aswell, but its better to do this right in my opinion.</p><p>Another option would be similar to your approach, have 2 events, one that is called OnNewFrame and wont be changed to keep lagacy support and add a new one which has the bahaviour i described. We then can add a check in AtmoLight what MP version is running and subscribe to the right event. If its the new version we check which frame we want to use and send that one to the existing method (AtmolightPlugin_OnNewFrame) for processing.</p><p></p><p>Hope i make sense <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile :)" loading="lazy" data-shortname=":)" />. Keep up the good work.</p></blockquote><p></p>
[QUOTE="Lightning303, post: 1127890, member: 97876"] In regards to AtmoLight, i dont think this is the right solution. I just flew over the patches, so maybe im missing something or misunderstanding. But from what i can see, you mainly renamed the event. In AtmoLight you added a new setting, to choose if one wants to use the new event. If this setting is enabled AtmoLight subscribes to the new event, if not, it tries to subscribe to the old one. But this only adds support for pre change and post change versions. Nothing else is added by this. If i enable the settings gui capture works, and if i watch a video and then minimize it, AtmoLight reveives the GUI data. If i disable this settings, MediaPortal Live Mode will only work during video playback, Live Mode in GUI (no media playback) is not working at all anymore. So instead of toggling which source should be used when we minimize a video (which was the idea of all of this), we now can toggle between "Show exactly what is on screen" and "Dont ever show GUI frames (AtmoLight behaviour from before 1.11pre). So why would i want to ever disable this with MP1.12 or ever enable this with older versions? It just adds confusion. Maybe the best approch is to let MediaPortal raise the OnNewFrame event on every new frame. So if we minimize a video, let an event get raised for every GUI frame and an event for every video frame. And then attach an identifier of where this frame came from (gui or video renderer). Then let ViewModeSwicther and AtmoLight decide which frame to use and which to discard. Yes, this means if you want to use a new MP version you would need to update AtmoLight to a new version aswell, but its better to do this right in my opinion. Another option would be similar to your approach, have 2 events, one that is called OnNewFrame and wont be changed to keep lagacy support and add a new one which has the bahaviour i described. We then can add a check in AtmoLight what MP version is running and subscribe to the right event. If its the new version we check which frame we want to use and send that one to the existing method (AtmolightPlugin_OnNewFrame) for processing. Hope i make sense :). Keep up the good work. [/QUOTE]
Insert quotes…
Verification
Post reply
Forums
MediaPortal 1
Development
Submit: code patches (MediaPortal/TV-Server/etc.)
Framegrabber improvement - Capture from UI when Video is minimized or running in Mini-display
Contact us
RSS
Top
Bottom