home
products
contribute
download
documentation
forum
Home
Forums
New posts
Search forums
What's new
New posts
All posts
Latest activity
Members
Registered members
Current visitors
Donate
Log in
Register
What's new
Search
Search
Search titles only
By:
New posts
Search forums
Search titles only
By:
Menu
Log in
Register
Navigation
Install the app
Install
More options
Contact us
Close Menu
Forums
MediaPortal 1
Development
Submit: code patches (MediaPortal/TV-Server/etc.)
Framegrabber improvement - Capture from UI when Video is minimized or running in Mini-display
Contact us
RSS
JavaScript is disabled. For a better experience, please enable JavaScript in your browser before proceeding.
You are using an out of date browser. It may not display this or other websites correctly.
You should upgrade or use an
alternative browser
.
Reply to thread
Message
<blockquote data-quote="Lightning303" data-source="post: 1127948" data-attributes="member: 97876"><p>Yeah i got that part <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite2" alt=";)" title="Wink ;)" loading="lazy" data-shortname=";)" />.</p><p></p><p></p><p>I see, i knew it wasnt calling the gui frames during video playback (minimized) before, because otherwise we would already end up with 2 frames. I assumed you had changed that, instead of checking if fullscreen in enabled and then choose what to grab. My bad <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite3" alt=":(" title="Frown :(" loading="lazy" data-shortname=":(" />.</p><p></p><p></p><p>Sill, its breaking allready working stuff. Using MP + AtmoLight last versions (1.15.1 and 1.11pre), MP Live Mode works in GUI (no playback), with your changes it doesnt anymore using the lagacy event (e.g. when the new setting is disabled or im not using a newer AtmoLight version).</p><p></p><p></p><p></p><p>I think its still possible as i described in my last post, a bit different, but still. Question is mainly if there should a second event or one (which breaks lagacy). If only AtmoLight is effected by this change, then i would say stay with 1 event. But its not my place to decide that <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite2" alt=";)" title="Wink ;)" loading="lazy" data-shortname=";)" />. You are doing the work and MP devs need to decide what they think is cleaner/better. If 2 events are being used, then i think the event that is in place now should not be changed at all. So it works like it does in 1.11pre.</p><p>For sending both frames, the OnFrame method, which you renamed into OnFrameGUI could be changed so that it would not choose which single frame to send with an if, but rather check if it has to send a second one.</p><p>[code]if (!GUIGraphicsContext.IsFullScreenVideo)</p><p>{</p><p> OnFrame();</p><p>}</p><p>OnNewFrame(width, height, arWidth, arHeight, pSurface);[/code]</p><p></p><p>So, if we are not in fullscreen send both, gui and video, if we are in fullscreen, only send video.</p><p></p><p>Of course both would have to be extended with an identifier. A nice enum e.g., so AtmoLight or any other plugin could choose which to use.</p></blockquote><p></p>
[QUOTE="Lightning303, post: 1127948, member: 97876"] Yeah i got that part ;). I see, i knew it wasnt calling the gui frames during video playback (minimized) before, because otherwise we would already end up with 2 frames. I assumed you had changed that, instead of checking if fullscreen in enabled and then choose what to grab. My bad :(. Sill, its breaking allready working stuff. Using MP + AtmoLight last versions (1.15.1 and 1.11pre), MP Live Mode works in GUI (no playback), with your changes it doesnt anymore using the lagacy event (e.g. when the new setting is disabled or im not using a newer AtmoLight version). I think its still possible as i described in my last post, a bit different, but still. Question is mainly if there should a second event or one (which breaks lagacy). If only AtmoLight is effected by this change, then i would say stay with 1 event. But its not my place to decide that ;). You are doing the work and MP devs need to decide what they think is cleaner/better. If 2 events are being used, then i think the event that is in place now should not be changed at all. So it works like it does in 1.11pre. For sending both frames, the OnFrame method, which you renamed into OnFrameGUI could be changed so that it would not choose which single frame to send with an if, but rather check if it has to send a second one. [code]if (!GUIGraphicsContext.IsFullScreenVideo) { OnFrame(); } OnNewFrame(width, height, arWidth, arHeight, pSurface);[/code] So, if we are not in fullscreen send both, gui and video, if we are in fullscreen, only send video. Of course both would have to be extended with an identifier. A nice enum e.g., so AtmoLight or any other plugin could choose which to use. [/QUOTE]
Insert quotes…
Verification
Post reply
Forums
MediaPortal 1
Development
Submit: code patches (MediaPortal/TV-Server/etc.)
Framegrabber improvement - Capture from UI when Video is minimized or running in Mini-display
Contact us
RSS
Top
Bottom