Reply to thread

Message: <blockquote data-quote="Lightning303" data-source="post: 1128072" data-attributes="member: 97876">The MP part looks good at first glance (only looking at patches atm). Will test laster today or tomorrow.The AtmoLight code however has some problems. Frames only have to be discarded when video is playing (g_Player.Playing) and we are not in fullscreen (!GUIGraphicsContext.IsFullScreenVideo). Then AtmoLight should determain which frame to throw away, so a new setting for users to choose how to behave is needed (as [USER=50482]@azzuro[/USER] wanted). So if idk how to call the new setting <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite7" alt=":p" title="Stick Out Tongue    :p" loading="lazy" data-shortname=":p" />, Settings.TrueGrabbing and FrameSource == FrameGrabber.FrameSource.Video -> return, and if !Settings.TrueGrabbing and FrameSource == FrameGrabber.FrameSource.GUI -> return.The menuEffect you are using in your patch holds the info which effect was last used for gui/menu content (no playback). playbackEffect holds the effect that is used when video/music etc is playing, no matter if fullscreen or not. But we wont need any of these. Also AtmolightPlugin_OnNewFrame will return automatically if the current effect is not MP Live mode (1st if in that method).Also if you are adding a new setting and you add that to the setupform, please use the dev branch (<a href="https://github.com/ambilight-4-mediaportal/AtmoLight/tree/DEV" target="_blank">https://github.com/ambilight-4-mediaportal/AtmoLight/tree/DEV</a>) as base. We changed the localisation and we would need to touch your code and translation strings a second time when we want to merge it <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite2" alt=";)" title="Wink    ;)" loading="lazy" data-shortname=";)" />.Thanks! <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile    :)" loading="lazy" data-shortname=":)" /></blockquote>

Verification