Fullscreen viz (1 Viewer)

[Anonymous]

As I didn't got any feedback on my bugreport http://nolanparty.com/mediaportal.sourceforge.net/phpBB2/viewtopic.php?t=4346&highlight= I checked out the sources and had a look how fullscreen viz is done.
Now i found this in AudioPlayerWMP9.SetVideoWindow():

[...]
      if (m_bFullScreen)
      {
        Log.Write("AudioPlayer:Fullscreen");

        m_iPositionX=GUIGraphicsContext.OverScanLeft;
        m_iPositionY=GUIGraphicsContext.OverScanTop;
        m_iWidth=GUIGraphicsContext.OverScanWidth;
        m_iHeight=GUIGraphicsContext.OverScanHeight;

        m_player.Location=new Point(0,0);
        m_player.ClientSize= new System.Drawing.Size(GUIGraphicsContext.Width,GUIGraphicsContext.Height);
        m_player.Size=new System.Drawing.Size(GUIGraphicsContext.Width,GUIGraphicsContext.Height);
        
        m_VideoRect=new Rectangle(0,0,m_player.ClientSize.Width,m_player.ClientSize.Height);
        m_SourceRect=m_VideoRect;
          
        //m_player.fullScreen=true;
        Log.Write("AudioPlayer:done");
        return;
      }
[...]

Now why is m_player.fullScreen=true; commented out? As far as i can see (after 30min. of MP code, so excuse me if that's not the case this is where the *real* fullscreen mode of the player is set. But somehow it has to have a reason why it is commented...?!?
Unfortunatly i can't test it myself, because i have an out of sync cvs version with build errors. I really hate the way fullscreen viz looks at the moment. Looks like i have a C64 or MSX or whatever old nice machine comes to mind...

 

[mPod]

Check out an older version for a compilable CVS, e.g. yesterday midnight.

 

[Anonymous]

nice tip, thanks. did that and made a test. terrible! No more fullscreen viz at all. Maybe i will investigate more but i'm tired now...
And i think someone else with MP knowledge will be a lot faster than me!

 

[Anonymous]

the player isnt set to fullscreen because MP uses the visual window defined by the "overscan window" settings in MP (the visual portion of the windows screen on a TV)

 

[Anonymous]

Aha ok. But then the resolution gets upsampled. i.e. 320x240 -> 1280x720? That's what makes it ugly, isn't it?
Besides: I think i had fullscreen working three weeks ago. Not sure though. Was in the beginning of my MP time. As i saw in CVS history nothing related to this has changed since revision 1.3. Stopped looking before that.
But then i'm asking myself what caused it to not working anymore? Any guesses? Or am i right, that the res is upsampled? When i resize the window in WMP10, it makes the same until switched to fullscreen. Then it takes the configuration from "Fullscreen resolution".

Edit:
Just a thought: Why do you make this overscan compensation for the viz? Who cares if some funky stars or whatever the viz displays is cut off?

 

[Anonymous]

*bump*

Sorry to bump this one, but nothing is going on in the viz section. It is a real show stopper! A viz with 320x240 on a projected screen of 3m x 2m just looks crap. Looks like in middle age... :-(

 

[dman_lfc]

Other things are more important now, post the request in the Feature Request section for the viz to take the PC's resolution into account and be patient.
Otherwise submit a patch and if it's good it will be put it.

DMAN