Getting comments on my patch (1 Viewer)

[Sven]

Hi,


more than seven months ago, I wrote a patch implementing "proper" WinLIRC support for MediaPortal. Unfortunately, no developer has ever commented on that patch. Did just no-one notice my post publishing the patch or is there a reason why it is not merged? Is there any chance the patch will be accepted?


Sven

 

[ziphnor]

I think in general that only the developers that are familiar with the affected part of the code will be willing to include such a patch. You should really check the SVN log files and see who created (or just worked alot) on the affected areas of MediaPortal.

Afterwards i suggest you contact them on IRC, as thats usually a safer bet than the forums.

I'm sorry that your patch has been lying around for 7 months, i hope it wont discourage you from future contributions (though i guess thats little comfort .

 

[diehard2]

Hi Sven,

I'll take a look at it, but as it might introduce problems, I will have to wait until after the next major release. Bump this is it doesn't happen then.

 

[Sven]

Thanks for your answers.

I'll take a look at it, but as it might introduce problems, I will have to wait until after the next major release. Bump this is it doesn't happen then.

That's fine, thanks.


Sven

 

[Sven]

Bump this is it doesn't happen then.

Bump!

 

[Darre]

I think the feature freeze is stopping them from adding it now.. they probably wont untill MP 1.0 is out.