Reply to thread

Message

<blockquote data-quote="pedu" data-source="post: 835430" data-attributes="member: 118288">First of all - i love this plugin. Not sure if it's being actively developed anymore, but I discovered a bug when two or more artists have released an album of the same name, likeArtist: Real LifeAlbum: HeartlandArtist: Sko &amp; TorpAlbum: HeartlandThe albums of course are completely different apart from sharing the album title. If I search for SomeTrackName which is included on the second album above the plugin finds the correct track and dispalys the result. Now if I select Enter on the track and choose to add the complete album to the playlist, the plugin adds the wrong album - in this case the album by Real Life, not the album by Sko &amp; Torp. Hope this can be easily fixed?Cheers,PeterJust took a look at the source and I think it's obvious why the wrong album is added to the playlist&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; ArrayList _album = new ArrayList();&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; String sAlbum = song.Album;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; MusicDatabase _mdb = MusicDatabase.Instance;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; bool _songsFound = _mdb.GetSongsByAlbum(sAlbum, ref _album);The method call _mdb.GetSongsByAlbum(sAlbum, ref _album) takes a string parameter and natutally returns the songs from the first found album with sAlbum name. For this to work it should take an albumId in the form of an integer to return the correct result, something like&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; ArrayList _album = new ArrayList();&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; integer AlbumId = song.AlbumId;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; MusicDatabase _mdb = MusicDatabase.Instance;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; bool _songsFound = _mdb.GetSongsByAlbumId(AlbumId, ref _album);Since I don't know the MediaPortal API I don't know if this is even possible?</blockquote>

[QUOTE="pedu, post: 835430, member: 118288"] First of all - i love this plugin. Not sure if it's being actively developed anymore, but I discovered a bug when two or more artists have released an album of the same name, like Artist: Real Life Album: Heartland Artist: Sko & Torp Album: Heartland The albums of course are completely different apart from sharing the album title. If I search for SomeTrackName which is included on the second album above the plugin finds the correct track and dispalys the result. Now if I select Enter on the track and choose to add the complete album to the playlist, the plugin adds the wrong album - in this case the album by Real Life, not the album by Sko & Torp. Hope this can be easily fixed? Cheers, Peter Just took a look at the source and I think it's obvious why the wrong album is added to the playlist ArrayList _album = new ArrayList(); String sAlbum = song.Album; MusicDatabase _mdb = MusicDatabase.Instance; bool _songsFound = _mdb.GetSongsByAlbum(sAlbum, ref _album); The method call _mdb.GetSongsByAlbum(sAlbum, ref _album) takes a string parameter and natutally returns the songs from the first found album with sAlbum name. For this to work it should take an albumId in the form of an integer to return the correct result, something like ArrayList _album = new ArrayList(); [I]integer AlbumId = song.AlbumId;[/I] MusicDatabase _mdb = MusicDatabase.Instance; bool _songsFound =[I] _mdb.GetSongsByAlbumId(AlbumId, ref _album);[/I] Since I don't know the MediaPortal API I don't know if this is even possible? [/QUOTE]

Verification