GUIMultiImage Bug Fix and Absolute Path Support (1 Viewer)

[fforde]

I have never submitted a bug fix for the core MediaPortal code before, so if this is the wrong place I apologize. If I need to be submitting this somewhere else I would appreciate it if someone could point me in the right direction.

While working on the Moving Pictures plug-in I ran into a minor bug in the GUIMultiImage class. Basically the class was not handling bad data supplied in the "imagepath" field, causing the skin rendering to halt. I have added additional error handling to the code and I have also added logic to check if the path is absolute rather than relative. The patch is based off of revision 20297.

If anyone has any questions, shoot me a PM.

 

[Paranoid Delusion]

Have PM'd gemx about above, but he's away atm, so he will see it when he gets back.

 

[fforde]

Was any action ever taken on this? Was this ever even reviewed? I am pretty passionate about MediaPortal, but I find it very discouraging that I get no response from any developers when I try to contribute to the core code.

 

[rtv]

Thanks for the heads up - I've just added your patch

 

[fforde]

Thanks rtv!

 

[tourettes]

Finally this has been commited to SVN. It was on my todo list for too long and rtv had a look on it.

0001706: GUIMultiImage Bug Fix and Absolute Path Support - MediaPortal Bugtracker

 

[tourettes]

ah, should have refreshed the browser before adding a comment