Reply to thread

Message

<blockquote data-quote="RoChess" data-source="post: 821782" data-attributes="member: 18896">Re: IMDb+ Scraper - Movie Scraping on Steroids v4.1.2IMDb+ scraper-script v4.1.2 is released.It fixes a problem introduced by the new CA/AU/NZ rating support from v4.1.1. This is because the new option is only added at scraper-script level, and not yet added to the IMDb+ plugin. This means there is no configuration entry for it in the options XML file. So inside the scraper-script I first configure the default value, which for this setting is &quot;01&quot; and then overwrite this via the options XML file.The problem I now find out (thanks to ibmonkey) is that when a config option is missing, it gets a value of 'false'. In other languages this equals &quot;00&quot;, so in my code when looking for &quot;01&quot; I actually look for &lt;=1 meaning I also accept 0 or any other value. Well this now turned out to not work properly (pretty sure it did on mine, but perhaps I had already manually added the config option to my options XML file and therefore never saw the 'bug').So I've added extra logic that verifies if the options XML file actually contains the value, which will preserve the default &quot;01&quot; value set before.Long story short, please enjoy v4.1.2 <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite6" alt=":cool:" title="Cool&nbsp; &nbsp; :cool:" loading="lazy" data-shortname=":cool:" /></blockquote>

[QUOTE="RoChess, post: 821782, member: 18896"] [b]Re: IMDb+ Scraper - Movie Scraping on Steroids v4.1.2[/b] IMDb+ scraper-script v4.1.2 is released. It fixes a problem introduced by the new CA/AU/NZ rating support from v4.1.1. This is because the new option is only added at scraper-script level, and not yet added to the IMDb+ plugin. This means there is no configuration entry for it in the options XML file. So inside the scraper-script I first configure the default value, which for this setting is "01" and then overwrite this via the options XML file. The problem I now find out (thanks to ibmonkey) is that when a config option is missing, it gets a value of 'false'. In other languages this equals "00", so in my code when looking for "01" I actually look for <=1 meaning I also accept 0 or any other value. Well this now turned out to not work properly (pretty sure it did on mine, but perhaps I had already manually added the config option to my options XML file and therefore never saw the 'bug'). So I've added extra logic that verifies if the options XML file actually contains the value, which will preserve the default "01" value set before. Long story short, please enjoy v4.1.2 :cool: [/QUOTE]

Verification