- Moderator
- #1
Hi,
Loving this plugin as I do I have been looking for a better way accessing it, I have in the past just modded the skin files to Hyperlink to it. This is ok unless you want to access from the now playing screen (using xface) which has no menu so getting to it requires far to many keypresses.
What I have done is patched the the code to add the MyLyrics option to the context menu for the NowPlaying screen, this is done in such a way that the option will only apprear in MyLyrics is installed and enabled, not full intergration but better than having to mod the skin files.
Before I submit this as a patch I wanted to check that
a) If this was something that people would find useful
b) For the more adventureous users some testing and feed back, attached is an archvie with the .dll and strings file.
The patch consists of a patched WindowsPlugins.dll and amended language file, english only. I have been testing this on my dev and live systems in addition to a couple of friends installations with no obivious problems but as my knowledge of the inner workings of MP is limited I would like to sure I have not intruduced some unexpected behaviour or to put it anther way...broken anything!
The patch is built on 0.2.3 Release and SVN 17932 (15th Feb)
As the kernal for this idea came from hwahrmann's GlobalSearch mod GlobalSearch will also appear as an option on the NowPlaying context menu if the plugin is installed and enabled.
Also included in the modified GUIMusicPlayingNow.cs for anyone intrested.
Thanks for your time
Trevor
Loving this plugin as I do I have been looking for a better way accessing it, I have in the past just modded the skin files to Hyperlink to it. This is ok unless you want to access from the now playing screen (using xface) which has no menu so getting to it requires far to many keypresses.
What I have done is patched the the code to add the MyLyrics option to the context menu for the NowPlaying screen, this is done in such a way that the option will only apprear in MyLyrics is installed and enabled, not full intergration but better than having to mod the skin files.
Before I submit this as a patch I wanted to check that
a) If this was something that people would find useful
b) For the more adventureous users some testing and feed back, attached is an archvie with the .dll and strings file.
The patch consists of a patched WindowsPlugins.dll and amended language file, english only. I have been testing this on my dev and live systems in addition to a couple of friends installations with no obivious problems but as my knowledge of the inner workings of MP is limited I would like to sure I have not intruduced some unexpected behaviour or to put it anther way...broken anything!
The patch is built on 0.2.3 Release and SVN 17932 (15th Feb)
As the kernal for this idea came from hwahrmann's GlobalSearch mod GlobalSearch will also appear as an option on the NowPlaying context menu if the plugin is installed and enabled.
Also included in the modified GUIMusicPlayingNow.cs for anyone intrested.
Thanks for your time
Trevor