Intergration of MyLyrics into MP (partial soloution) (1 Viewer)

trevor

Portal Pro
October 17, 2006
1,601
952
Chelmsford
Home Country
United Kingdom United Kingdom
Hi,

Loving this plugin as I do I have been looking for a better way accessing it, I have in the past just modded the skin files to Hyperlink to it. This is ok unless you want to access from the now playing screen (using xface) which has no menu so getting to it requires far to many keypresses.

What I have done is patched the the code to add the MyLyrics option to the context menu for the NowPlaying screen, this is done in such a way that the option will only apprear in MyLyrics is installed and enabled, not full intergration but better than having to mod the skin files.

Before I submit this as a patch I wanted to check that

a) If this was something that people would find useful

b) For the more adventureous users some testing and feed back, attached is an archvie with the .dll and strings file.

The patch consists of a patched WindowsPlugins.dll and amended language file, english only. I have been testing this on my dev and live systems in addition to a couple of friends installations with no obivious problems but as my knowledge of the inner workings of MP is limited I would like to sure I have not intruduced some unexpected behaviour or to put it anther way...broken anything!

The patch is built on 0.2.3 Release and SVN 17932 (15th Feb)

As the kernal for this idea came from hwahrmann's GlobalSearch mod GlobalSearch will also appear as an option on the NowPlaying context menu if the plugin is installed and enabled.

Also included in the modified GUIMusicPlayingNow.cs for anyone intrested.


Thanks for your time

Trevor
 

MEGA180

Portal Pro
January 8, 2007
102
5
62
Home Country
France France
Very useful. I just tried it on the new 1.0 RC1 version and it seems to work. I just had to modify the french string file.
I noticed when you install the plugin myfilms it adds lines in the string file so copying yours directly might lose some strings.
I did not find the global search option (don't what it is, not enabled on my system).
Is it possible to go back from lyrics to playing now screen ?
Thanks !
 

MEGA180

Portal Pro
January 8, 2007
102
5
62
Home Country
France France
So after a little use I think there is a bug with MPsetup. I tried to install a new plugin (Myprogram) and I could not enable it. I expierienced also one or two messages when I closed MP saying it crashed closing.
These problems disappared when restoring the original windowsplugins.dll.
But I still want to use it !
 

trevor

Portal Pro
October 17, 2006
1,601
952
Chelmsford
Home Country
United Kingdom United Kingdom
  • Thread starter
  • Moderator
  • #4
So after a little use I think there is a bug with MPsetup. I tried to install a new plugin (Myprogram) and I could not enable it. I expierienced also one or two messages when I closed MP saying it crashed closing.
These problems disappared when restoring the original windowsplugins.dll.
But I still want to use it !

Hi,

I have no more with this as up till now no one showed any interest.

The current feature freeze situation with RC1 means enhancements will not considered untill after the full release. I suspect there have been a few changes and the .dll in the post is out of date.

I can in this thread provide an updated version for those who want to use it, please be aware this will provided as is and at own risk...keep a copy of the original and always switch back if reporting MP problems in the forums.

The Global Search intergation was removed prior to RC1 release, from what I remember the code was not quiet right and caused some problems.

Will look at the issues you described this weekend and post an updated .dll

Thanks

Trevor
 

trevor

Portal Pro
October 17, 2006
1,601
952
Chelmsford
Home Country
United Kingdom United Kingdom
  • Thread starter
  • Moderator
  • #8
I have refreshed this mod for MP1 RC1 with SVN. Give this is go and see if the MyPrograms/Crash is solved - seems ok on my system.

I will grab the MyLyrics code and see why it jumps back to the plugins screen.

I have still included the language files but it is best if just the 2 required lines are addedd to the bottom of the current language file.

Cheers
 

MEGA180

Portal Pro
January 8, 2007
102
5
62
Home Country
France France
Thank you. I'll let you know how it works. I'll post the link on the french forum.

I don't know where to copy GUIMusicPlayingNow.cs. In the script folder ?
 

MEGA180

Portal Pro
January 8, 2007
102
5
62
Home Country
France France
I've expierienced two new problems : no more topbar menu.
MySudoku does not work anymore.
Any idea ?
 

Users who are viewing this thread

Top Bottom