Reply to thread

Message

<blockquote data-quote="morpheus_xx" data-source="post: 1131078" data-attributes="member: 48495">The &quot;Default&quot; skin of MP2 is the base for all other skins. It's developed as a basic, fast and extensible skin. It's designed as 1280x720 resolution. All (or the majority) of the other Skins (Reflexion, Titanium, ApolloOne, BlueVision) are full HD (1920x1080). Because of the MP2 skin resource lookup chain, a fallback for missing screens and resources happens, selection the &quot;Default&quot; versions in the end.Where is the problem?Inbuilt plugins come with Skin support for Default, some of them also for Reflexion and Titanium. The most differences come from defined constants, like image sizes, grid widths, margins etc. So to add support for greater sizes requires some changes to support all new 1080 Skins.How can we solve this?My idea is to define constants inside Skins for both common sizes: 720 and 1080.I've created a custom MultiValueConverter which decides internally if it should use the first or second argument (720 or 1080 resolution).The XAML attributes then should use the new converter and bind both 720/1080 resources to it. It's not much more work then using single resources, but save all other designers most of the work.ExamplesWeather icon: [CODE=XML]&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;Image x:Name=&quot;BigIcon&quot; Source=&quot;{Binding CurrentLocation.Condition.BigIconProperty}&quot; Stretch=&quot;Uniform&quot;&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;Image.Width&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;MultiBinding Converter=&quot;{StaticResource SkinResolutionMultiValueConverter}&quot;&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;Binding Source=&quot;{StaticResource WeatherIconBigWidth720}&quot;/&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;Binding Source=&quot;{StaticResource WeatherIconBigWidth1080}&quot;/&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;/MultiBinding&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;/Image.Width&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;Image.Height&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;MultiBinding Converter=&quot;{StaticResource SkinResolutionMultiValueConverter}&quot;&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;Binding Source=&quot;{StaticResource WeatherIconBigHeight720}&quot;/&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;Binding Source=&quot;{StaticResource WeatherIconBigHeight1080}&quot;/&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;/MultiBinding&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;/Image.Height&gt;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &lt;/Image&gt;[/CODE]Where the constants are defined as:[CODE=XML]&nbsp; &lt;ResourceWrapper x:Key=&quot;WeatherIconBigWidth720&quot;&gt;128&lt;/ResourceWrapper&gt;&nbsp; &lt;ResourceWrapper x:Key=&quot;WeatherIconBigHeight720&quot;&gt;128&lt;/ResourceWrapper&gt;&nbsp; &lt;ResourceWrapper x:Key=&quot;WeatherIconBigWidth1080&quot;&gt;192&lt;/ResourceWrapper&gt;&nbsp; &lt;ResourceWrapper x:Key=&quot;WeatherIconBigHeight1080&quot;&gt;192&lt;/ResourceWrapper&gt;[/CODE]So it's now no longer required to define the same constants for each 1080 skin over and over again, but only once inside the plugin.Full changes for &quot;Weather&quot;: <a href="https://github.com/MediaPortal/MediaPortal-2/commit/6b13c779e604a601d32be539cf9d08933d579510" target="_blank">https://github.com/MediaPortal/MediaPortal-2/commit/6b13c779e604a601d32be539cf9d08933d579510</a>Same for &quot;News&quot;: <a href="https://github.com/MediaPortal/MediaPortal-2/commit/3e13557b0ad3a43baa09ebb317f4e251f1003983" target="_blank">https://github.com/MediaPortal/MediaPortal-2/commit/3e13557b0ad3a43baa09ebb317f4e251f1003983</a>This change is especially thought for all new Skins which are under development (ApolloOne + BlueVision). [USERGROUP=38]@Designers[/USERGROUP]&nbsp; and [USERGROUP=39]@Developers[/USERGROUP]</blockquote>

[QUOTE="morpheus_xx, post: 1131078, member: 48495"] The "Default" skin of MP2 is the base for all other skins. It's developed as a basic, fast and extensible skin. It's designed as 1280x720 resolution. All (or the majority) of the other Skins (Reflexion, Titanium, ApolloOne, BlueVision) are full HD (1920x1080). Because of the MP2 skin resource lookup chain, a fallback for missing screens and resources happens, selection the "Default" versions in the end. [U]Where is the problem?[/U] Inbuilt plugins come with Skin support for Default, some of them also for Reflexion and Titanium. The most differences come from defined constants, like image sizes, grid widths, margins etc. So to add support for greater sizes requires some changes to support all new 1080 Skins. [U] How can we solve this?[/U] My idea is to define constants inside Skins for both common sizes: 720 and 1080. I've created a custom MultiValueConverter which decides internally if it should use the first or second argument (720 or 1080 resolution). The XAML attributes then should use the new converter and bind both 720/1080 resources to it. It's not much more work then using single resources, but save all other designers most of the work. [U]Examples[/U] Weather icon: [CODE=XML] <Image x:Name="BigIcon" Source="{Binding CurrentLocation.Condition.BigIconProperty}" Stretch="Uniform"> <Image.Width> <MultiBinding Converter="{StaticResource SkinResolutionMultiValueConverter}"> <Binding Source="{StaticResource WeatherIconBigWidth720}"/> <Binding Source="{StaticResource WeatherIconBigWidth1080}"/> </MultiBinding> </Image.Width> <Image.Height> <MultiBinding Converter="{StaticResource SkinResolutionMultiValueConverter}"> <Binding Source="{StaticResource WeatherIconBigHeight720}"/> <Binding Source="{StaticResource WeatherIconBigHeight1080}"/> </MultiBinding> </Image.Height> </Image>[/CODE] Where the constants are defined as: [CODE=XML] <ResourceWrapper x:Key="WeatherIconBigWidth720">128</ResourceWrapper> <ResourceWrapper x:Key="WeatherIconBigHeight720">128</ResourceWrapper> <ResourceWrapper x:Key="WeatherIconBigWidth1080">192</ResourceWrapper> <ResourceWrapper x:Key="WeatherIconBigHeight1080">192</ResourceWrapper>[/CODE] So it's now no longer required to define the same constants for each 1080 skin over and over again, but only once inside the plugin. Full changes for "Weather": [URL]https://github.com/MediaPortal/MediaPortal-2/commit/6b13c779e604a601d32be539cf9d08933d579510[/URL] Same for "News": [URL]https://github.com/MediaPortal/MediaPortal-2/commit/3e13557b0ad3a43baa09ebb317f4e251f1003983[/URL] This change is especially thought for all new Skins which are under development (ApolloOne + BlueVision). [USERGROUP=38]@Designers[/USERGROUP] and [USERGROUP=39]@Developers[/USERGROUP] [/QUOTE]

Verification