[Approved] Making LastFM streams behave not as radio for more information in MiniDisplay/overlay (1 Viewer)

Hodor

Portal Member
September 5, 2008
36
4
Home Country
Denmark Denmark
When a stream is flagged as radio, only a very few properties are exposed via MiniDisplay.

LastFM can be argued to be a radio, but it is also 'just' MP3 files streamed. Therefor if LastFM streams isn't flagged as radio you get the track duration and album exposed in MiniDisplay and in the skin Music overlays. You then also have the MiniDisplay EQ working for LastFM.

This little change makes LastFM feel like a complete MP3 jukebox in MP
 

Attachments

  • lastfm_bassplayer.patch
    30.7 KB

rtv

Retired Team Member
  • Premium Supporter
  • April 7, 2005
    3,622
    301
    Osnabruck
    Home Country
    Germany Germany
    AW: Making LastFM streams behave not as radio for more information in MiniDisplay/ove

    The radio type has an historical background. It was used when last.fm didn't supply single mp3 urls but one contineous stream.
    However as this functionality has been deprecated and removed since I guess your patch is safe.

    Please also try the various crossover settings while switching from running last.fm playback to mp3 files in MyMusic just to be sure.
     

    Hodor

    Portal Member
    September 5, 2008
    36
    4
    Home Country
    Denmark Denmark
    Re: AW: Making LastFM streams behave not as radio for more information in MiniDisplay

    As far as I can tell, the isLastFM flag is untouched so that triggers some special handling of crossover/fade stuff as it should. For normal mp3 both isradio and islastfm should be false, just as before the patch.

    I haven't had issues with normal playback of mp3, but I only use that rarely. I normally listen to LastFM when I'm in mood for music. Perhaps because my music collection sucks ;-)
     

    chemelli

    Retired Team Member
  • Premium Supporter
  • September 28, 2006
    6,159
    2,264
    49
    Milano, Italy
    Home Country
    Italy Italy
    Re: Making LastFM streams behave not as radio for more information in MiniDisplay/ove

    Ralf,

    what should we do with this ?

    Simone
     

    jameson_uk

    Retired Team Member
  • Premium Supporter
  • January 27, 2005
    7,258
    2,528
    Birmingham
    Home Country
    United Kingdom United Kingdom
    Re: Making LastFM streams behave not as radio for more information in MiniDisplay/ove

    Added in SVN 26898
     

    Users who are viewing this thread

    Top Bottom