[fixed] Mantis 2853: Editing channel fix (1 Viewer)

sunedane

Portal Member
November 30, 2008
16
5
Home Country
Denmark Denmark
Hi.

After gemx checked in his fix for mantis 2853 (Revision 26251) the polarisation values on Editing DVB-S channels, does not match the value you get from channel scan. Its properly because the index is changed while adding NotSet and NotDefined.

Horizontal values are stored as 1 in the database from a channel scan, but its read as NotSet in FormDVBSTuningDetails.
Vertical values are stored as 2 in the database from a channel scan, but its read as NotDefined in FormDVBSTuningDetails.

So, if you change the value from within the form you gets the wrong value. Horizontal = 3 and Vertical = 4...

Regards
Sune
 

mm1352000

Retired Team Member
  • Premium Supporter
  • September 1, 2008
    21,577
    8,224
    Home Country
    New Zealand New Zealand
    Hi sunedane

    I can confirm that there is a bug with the polarity field. Thank you for reporting it :)
     

    mm1352000

    Retired Team Member
  • Premium Supporter
  • September 1, 2008
    21,577
    8,224
    Home Country
    New Zealand New Zealand
    Hi there

    There is already a patch attached to the mantis issue :oops:
    I'm new to this - still figuring out the process. Should I commit?
     

    mm1352000

    Retired Team Member
  • Premium Supporter
  • September 1, 2008
    21,577
    8,224
    Home Country
    New Zealand New Zealand
    Hi DJBlu and SilentException

    Sorry for the confusion - I should have said something here. I had raised a new issue (3223) and posted my patch there. I didn't get SVN access until tonight so have only just committed it (rev 26899). Also wasn't quite certain of the process since this is my first official bugfix.

    Once again, sorry for the confusion...
     

    Attachments

    • Mantis 3223.patch
      4.9 KB

    Users who are viewing this thread

    Top Bottom