[Rejected] Masking of thumb and imagefolder for filmstrip (1 Viewer)

[pilehave]

Hi!

The attached patch allows skinners to use masks in filmstripview, similar to the one in coverflow. See the attached screenshot.

Only real "problem" atm is that any frame that is used is not masked. When I try to mask it the skinengine screws up. Maybe fixable?

So...use

<showFrame>no</showFrame>

in the facadeview.

And use

<imageFolder>thumbnail_frame_shine.png</imageFolder>
<imageFolderFocus>thumbnail_frame_shine.png</imageFolderFocus>

to show a frame that is masked correctly.

 

[joostzilla]

And how about having this in thumbviews? We already can pseudo mask the thumbs but it would be better to have the same masks as in coverflow.

 

[pilehave]

I have compiled a version with masked thumbnails, but it had severe sideeffects with scaling and weird placement of thumbs. I think it's a problem within the masking itself, and I contacted Andy to have him take a look at the code behind it.

 

[DieBagger]

Afaik this is already in svn since rev 26760:

Revision: 26760
Author: ajp5199
Date: 03:32:55, 14 November 2010
Message:
Updated GUIThumbnailPanel to allow for image masking on a granular basis. Implemented image masking for GUIFilmstripControl.
----
Modified : /trunk/mediaportal/Core/guilib/GUIFilmstripControl.cs
Modified : /trunk/mediaportal/Core/guilib/GUIThumbnailPanel.cs

So I marked the patch as rejected, objections?

 

[pilehave]

No objections. I had trouble making a patch for thumbnails, but then Andy (ajp) fixed the viewport for thumbnails, and fixed filmstrip at the same time. I'm happy

 

[DieBagger]

Well theres still a few issues with the facade but I hope we can get them fixed for the beta...