Reply to thread

Message

<blockquote data-quote="mm1352000" data-source="post: 1139870" data-attributes="member: 82144">[USER=107951]@georgius[/USER] I found a problem in the current IPTV filter. A certain section of code is causing PMT sections to be thrown away:<a href="https://github.com/MediaPortal/MediaPortal-1/blob/master/DirectShowFilters/MPIPTVSource/MPIPTVSource/MPIPTVSourceStream.cpp#L521" target="_blank">https://github.com/MediaPortal/MediaPortal-1/blob/master/DirectShowFilters/MPIPTVSource/MPIPTVSource/MPIPTVSourceStream.cpp#L521</a>The problem happens when:<ul>
<li data-xf-list-type="ul">TS contains more than one program</li>
<li data-xf-list-type="ul">PMT for more than one program is carried on the same PID</li>
<li data-xf-list-type="ul">a TS packet contains more than one PMT section</li>
</ul>The code accepts and parses the first section in the packet. That is okay. However, it throws away the remaining data in the packet, which could contain additional PMT sections (or at least the start of the next PMT section).Also, it seems like this code:<a href="https://github.com/MediaPortal/MediaPortal-1/blob/master/DirectShowFilters/MPIPTVSource/MPIPTVSource/MPIPTVSourceStream.cpp#L493" target="_blank">https://github.com/MediaPortal/MediaPortal-1/blob/master/DirectShowFilters/MPIPTVSource/MPIPTVSource/MPIPTVSourceStream.cpp#L493</a>...only does what it is intended to do when the PMT section is aligned with the start of the TS packet. This will not always be the case, even when the TS only contains one program. For example, if the PMT section is larger than 183 bytes (ie. requires more than one packet). In this case, &quot;if (pmtParser-&gt;IsValidPacket())&quot; will fail.</blockquote>

[QUOTE="mm1352000, post: 1139870, member: 82144"] [USER=107951]@georgius[/USER] I found a problem in the current IPTV filter. A certain section of code is causing PMT sections to be thrown away: [URL]https://github.com/MediaPortal/MediaPortal-1/blob/master/DirectShowFilters/MPIPTVSource/MPIPTVSource/MPIPTVSourceStream.cpp#L521[/URL] The problem happens when: [LIST] [*]TS contains more than one program [*]PMT for more than one program is carried on the same PID [*]a TS packet contains more than one PMT section [/LIST] The code accepts and parses the first section in the packet. That is okay. However, it throws away the remaining data in the packet, which could contain additional PMT sections (or at least the start of the next PMT section). Also, it seems like this code: [URL]https://github.com/MediaPortal/MediaPortal-1/blob/master/DirectShowFilters/MPIPTVSource/MPIPTVSource/MPIPTVSourceStream.cpp#L493[/URL] ...only does what it is intended to do when the PMT section is aligned with the start of the TS packet. This will not always be the case, even when the TS only contains one program. For example, if the PMT section is larger than 183 bytes (ie. requires more than one packet). In this case, "if (pmtParser->IsValidPacket())" will fail. [/QUOTE]

Verification