Minor fix of Danish characters in Teletext (1 Viewer)

johnlc

Portal Pro
April 19, 2008
59
3
Horsens
Home Country
Denmark Denmark
I have noticed that a few danish characters is wrong in the translation tables. Here is example from TeletextPageRenderer.cs in TVClient Plugin
m_charTableC
{ 'Æ', 'Ø', 'Å', 'Ü', '_', 'é' },
Notice Æ Ø Å in group txtLanguage=11

m_charTableD
{ 'æ', 'ø', 'å', 'ü' }
Notice æ ø å in group txtLanguage=11.

This fix I have tried and it works in TVClient Plugin (may be in other places too)

The is not a major thing, but maybe it could be fixed at some point :)
 

gibman

Retired Team Member
  • Premium Supporter
  • October 4, 2006
    2,998
    1,372
    Aarhus
    Home Country
    Denmark Denmark
    Could u supply me with a diff/patch file of the changes made ?

    this is for teletext TV only ?
    Or teletext based subtitles also ?

    /gibman
     

    johnlc

    Portal Pro
    April 19, 2008
    59
    3
    Horsens
    Home Country
    Denmark Denmark
    Yes, I think the issue is both places, but I have been strugling with Oracle database since friday evening - so give me a few days :)
     

    johnlc

    Portal Pro
    April 19, 2008
    59
    3
    Horsens
    Home Country
    Denmark Denmark
    Could u supply me with a diff/patch file of the changes made ?

    this is for teletext TV only ?
    Or teletext based subtitles also ?

    /gibman

    Here is the the places I think it should be changed. It wouldn't accept .diff, so they are called .txt
     

    Attachments

    • Mediaportal.diff.txt
      30.6 KB

    johnzered

    Retired Team Member
  • Premium Supporter
  • April 20, 2008
    358
    80
    Home Country
    Finland Finland
    Hello!

    As a coincidence I tried the teletext with the latest tvplugin. And now I also have the danish characters, at least theese two are now wrong:
    Æ/æ instead of Ä/ä
    and Ø/ø instead of Ö/ö
    It could be more that is wrong but theese two I saw instantly. Could you try to find a fix that would satisfy us all? I know this behavior will not be very welcome in at least Finland and Sweden.

    //johnzered
     

    johnlc

    Portal Pro
    April 19, 2008
    59
    3
    Horsens
    Home Country
    Denmark Denmark
    No I can believe that.
    But it should only affect what is called txtLanguage=11 in the code. I will have a look at it tonight.
     

    johnlc

    Portal Pro
    April 19, 2008
    59
    3
    Horsens
    Home Country
    Denmark Denmark
    Well I may have opened the box of Pandora here, because this wont be easy. Somehow it must be possible to detect, DK,S,N,SF (and Iceland?) further The Faroes and Greenland may also apply to the same language code=2

    As you can see below my test shows that DK&S both use byte 115 and N uses 100 (but is this persistent?)
    But here are my findings, and a clip from something about Teletext character sets I found.
    Maybe Gibman needs to rollback the changes for now - until a better solution comes around.
    I don't want to create to many complaints for the team as they are doing an excellent job - and don't need this disturbance right now- I can compile my own for the time being ( just as johnzered said about Ø/ø, I can say that the characters Ö/ö are not welcome on my screen :D )

    Findings and documentation:
    Danish
    2008-06-17 17:49:22.190000 [Info.][Teletext Updater]: JLC: Byte:115 Hamming:5
    2008-06-17 17:49:22.190000 [Info.][Teletext Updater]: JLC: Language code 2
    2008-06-17 17:49:22.191000 [Info.][Teletext Updater]: JLC: txtLanguage 11

    Swedish
    2008-06-17 17:49:46.929000 [Info.][Teletext Updater]: JLC: Byte:115 Hamming:5
    2008-06-17 17:49:46.929000 [Info.][Teletext Updater]: JLC: Language code 2
    2008-06-17 17:49:46.929000 [Info.][Teletext Updater]: JLC: txtLanguage 11

    Norway
    2008-06-17 17:50:34.620000 [Info.][Teletext Updater]: JLC: Byte:100 Hamming:4
    2008-06-17 17:50:34.621000 [Info.][Teletext Updater]: JLC: Language code 2
    2008-06-17 17:50:34.621000 [Info.][Teletext Updater]: JLC: txtLanguage 11

    Documentation found on Internet:

    The remaining flags are called ``Suppress header'', ``Update'', ``Interrupted Sequence'', ``Inhibit Display'' and ``Magazine Serial''.
    There are also three control bits which can be used to select one of 8 national character sets.
    All 8 sets share the same basic 83 characters but modify the remaining 13 characters
    (23=# 24=$ 40=@ 5B=[ 5C=\ 5D=] 5E=^ 5F=_ 60=` 7B={ 7C=| 7D=} 7E=~).
    Unfortunately, there are more National options defined than there are bits to represent them,
    so the right decoders must be used in the right region:

    Control National
    Bits Character Option
    000 English or Polish
    001 German
    010 Swedish
    011 Italian
    100 French
    101 Spanish or Serbo-croat
    110 Turkish or Czechoslovakia
    111 Rumanian

    PS
    The attached tvplugin.dll is if someone wants to see the codes for their country,put it in mediaportal\plugins\windows
    Remember to keep your old copy!!
    It only works for the TVclient plugin, I guess.
    You can see the lines in Mediaportal.log file.
     

    dhasselqvist

    Member
    November 20, 2007
    75
    8
    Home Country
    Sweden Sweden
    Findings and documentation:
    Danish
    2008-06-17 17:49:22.190000 [Info.][Teletext Updater]: JLC: Byte:115 Hamming:5
    2008-06-17 17:49:22.190000 [Info.][Teletext Updater]: JLC: Language code 2
    2008-06-17 17:49:22.191000 [Info.][Teletext Updater]: JLC: txtLanguage 11

    Swedish
    2008-06-17 17:49:46.929000 [Info.][Teletext Updater]: JLC: Byte:115 Hamming:5
    2008-06-17 17:49:46.929000 [Info.][Teletext Updater]: JLC: Language code 2
    2008-06-17 17:49:46.929000 [Info.][Teletext Updater]: JLC: txtLanguage 11

    Norway
    2008-06-17 17:50:34.620000 [Info.][Teletext Updater]: JLC: Byte:100 Hamming:4
    2008-06-17 17:50:34.621000 [Info.][Teletext Updater]: JLC: Language code 2
    2008-06-17 17:50:34.621000 [Info.][Teletext Updater]: JLC: txtLanguage 11

    If the same codes are used for different languages then we might need to use a user setting to get the correct characters. Right now we are choosing a language in the configuration of mediaportal. Why not use that setting to get the right characters?
     

    johnlc

    Portal Pro
    April 19, 2008
    59
    3
    Horsens
    Home Country
    Denmark Denmark
    If the same codes are used for different languages then we might need to use a user setting to get the correct characters. Right now we are choosing a language in the configuration of mediaportal. Why not use that setting to get the right characters?

    dhasselqvist,
    Any chance that you can try this TVplugin.dll (for the latest SVN) - here I have tried to get this language.
    It should be put in \Mediaportal\plugins\windows - but remember to keep your old TVplugin.dll, so that you can replace it again.
    Danish:
    2008-06-24 14:11:54.833440 [Info.][Teletext Updater]: JLC: Byte:115 Hamming:5
    2008-06-24 14:11:54.833440 [Info.][Teletext Updater]: JLC: Language code 2
    2008-06-24 14:11:54.833440 [Info.][Teletext Updater]: JLC: txtLanguage 13 (Danish)

    Swedish:
    2008-06-24 14:13:25.475440 [Info.][Teletext Updater]: JLC: Byte:115 Hamming:5
    2008-06-24 14:13:25.475440 [Info.][Teletext Updater]: JLC: Language code 2
    2008-06-24 14:13:25.475440 [Info.][Teletext Updater]: JLC: txtLanguage 11 (Swedish)

    If you are satisfied, then which countries are affected?
    Denmark,Norway use Æ,Ø
    Sweden, Finland uses Ä,Ö
    But Iceland, Faroe Islands - I simply don't know what they use, but everybody seemed happy until I stuck my nose in so I guess it's just a DK thing and N.
     

    Users who are viewing this thread

    Top Bottom