"More information about artist/album" doesn't work (1 Viewer)

[morskipas]

Hi folks,

i have a problem in the music plugin.
Always when i go to "more informations about artist/album" i get the message "no album found".
Is there any setting to activate this function?


morskipas

 

[pilehave]

You need to explain a bit better. Where to you see such a link/button? Perhaps you could make a screenshot

 

[morskipas]

AW: "More information about artist/album" doesn't work

Hi pilehave,

thx for your very quick answer.
i do the following.
I go to "My Music" -> i select a album an go to the tracklist -> a press the info button on my remote to get the kontextmenu
then i select the entry "show info about the album/artist" then i get a little popup-message "No album found"

thx for your support
morskipas

 

[robyf]

Which version of MP are you on? There was a bug with this functionality thas has been already fixed for 1.2.0b.

 

[morskipas]

AW: "More information about artist/album" doesn't work

Hi Roby,

i use the version 1.1.2 at the moment and the skin streamedMP.

Kind regards
morskipas

 

[pilehave]

Which version of MP are you on? There was a bug with this functionality thas has been already fixed for 1.2.0b.

I can confirm this issue here.

In which version is it supposed to be fixed? I see it in SVN 27138 here (which is newer than both 1.1.2 and 1.2.0 Alpha).

I can show artist/album info from the music-folder on the album, but when I enter the album (tracklist) it doesn't do anything when choosing "Show album/artist info".

This is all in shares view. In databaseview it works as it should.

 

[catavolt]

AW: "More information about artist/album" doesn't work

Seems to be a new introduced bug...

 

[jameson_uk]

Re: AW: "More information about artist/album" doesn't work

Seems to be a new introduced bug...

The album/artist lookup has not changed in ages and looks like this has always been a bug. Never got round to reworking that code. I will see what is different between database and shares code

 

[pilehave]

Re: AW: "More information about artist/album" doesn't work

Seems to be a new introduced bug...

The album/artist lookup has not changed in ages and looks like this has always been a bug. Never got round to reworking that code. I will see what is different between database and shares code

I decided to dig into this, and I got it working. Don't know if this is the correct approach, but it is a solution

Can't see any sideeffects, but please do test.

The patch is created against SVN 27138

Index: GUIMusicFiles.cs
===================================================================
--- GUIMusicFiles.cs	(revision 27138)
+++ GUIMusicFiles.cs	(working copy)
@@ -999,6 +999,10 @@
     protected override void OnInfo(int iItem)
     {
       GUIListItem pItem = facadeLayout[iItem];
+      if (pItem == null)
+      {
+        return;
+      }
 
       if (pItem.IsFolder && pItem.Label != "..")
       {
@@ -1032,16 +1036,19 @@
         }
       }
 
+
       Song song = pItem.AlbumInfoTag as Song;
 
-      if (song == null)
+      if (song == null && pItem != null)
       {
-        List<GUIListItem> list = new List<GUIListItem>();
-        list.Add(pItem);
-        GetTagInfo(ref list);
+        MusicTag tag = pItem.MusicTag as MusicTag;
+        if (tag != null && tag.Album.Length > 0)
+        {
+          ShowAlbumInfo(true, tag.Artist, tag.Album, pItem.Path, tag);
+          facadeLayout.RefreshCoverArt();
+        }
       }
 
-      //facadeLayout.RefreshCoverArt();
       base.OnInfo(iItem);
     }

PS: I didn't see the purpose for this code, but I left it in anyway:

-        List<GUIListItem> list = new List<GUIListItem>();
-        list.Add(pItem);
-        GetTagInfo(ref list);

 

[jameson_uk]

The GetTagInfo code is to read the tags / CD info but should not be needed any more.

I have a feeling that simply removing the whole OnInfo code in GUIMusicFiles.cs will actually solve the problem but have not had chance to check yet